Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a Network segmentation Cheat Sheet? #1031

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Release a Network segmentation Cheat Sheet? #1031

merged 1 commit into from
Jan 2, 2023

Conversation

sergiomarotco
Copy link
Contributor

Try to release Network segmentation Cheat Sheet from https://github.com/OWASP/CheatSheetSeries/blob/master/cheatsheets_draft/Network_Segmentation_Cheat_Sheet.md

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

@AgoraSecurity
Copy link
Contributor

I think it makes more sense if this PR is a file mv (git mv) instead of a new file

@szh szh mentioned this pull request Dec 27, 2022
8 tasks
@mackowski
Copy link
Collaborator

mackowski commented Jan 2, 2023

@sergiomarotco can you please add ".md" file extension at the end of the filename?

@jmanico
Copy link
Member

jmanico commented Jan 2, 2023

This is great but can you add it to the draft folder while we review if you want to merge it now?

@jmanico jmanico merged commit 8e8c7ba into OWASP:master Jan 2, 2023
@sergiomarotco sergiomarotco deleted the patch-1 branch January 3, 2023 13:55
@sergiomarotco sergiomarotco restored the patch-1 branch January 3, 2023 13:55
@sergiomarotco sergiomarotco deleted the patch-1 branch January 3, 2023 13:56
@sergiomarotco
Copy link
Contributor Author

C7D17A63-B398-4544-B0C5-F9487FDB4E0E
Why images not visible on site owasp.org?

@AgoraSecurity
Copy link
Contributor

My hunch is that it's because lint is failing: https://github.com/OWASP/CheatSheetSeries/actions/runs/3825640619/jobs/6508782030

@jmanico
Copy link
Member

jmanico commented Jan 3, 2023

I fixed all of these links, better?

@sergiomarotco
Copy link
Contributor Author

I fixed all of these links, better?

It seems so

@sergiomarotco
Copy link
Contributor Author

sergiomarotco commented Jan 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants