Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cluster-announce-hostname only support in redis 7 #69

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Jan 18, 2024

see: https://github.com/redis/redis/blob/7.0/redis.conf

When build image with redis 6.2.*, the startup log shows:

 Running without TLS mode
 ACL_MODE is not true, skipping ACL file modification
 Starting redis service in cluster mode.....

 *** FATAL CONFIG FILE ERROR (Redis 6.2.12) ***
 Reading the configuration file, at line 25
 >>> 'cluster-announce-hostname "new-redis-cluster111-leader-0"'
 Bad directive or wrong number of arguments

So we should remove the param setting when REDIS_MAJOR_VERSION settting to v7

@drivebyer drivebyer added the bug Something isn't working label Jan 18, 2024
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk shubham-cmyk merged commit 0b2efdc into OT-CONTAINER-KIT:master Jan 18, 2024
6 checks passed
@drivebyer drivebyer deleted the fix-redis-6 branch January 18, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants