Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance log every reconcile redis replication #780

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

drivebyer
Copy link
Collaborator

close #764

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a143001) 32.70% compared to head (35ff280) 32.78%.
Report is 3 commits behind head on master.

Files Patch % Lines
controllers/redisreplication_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   32.70%   32.78%   +0.08%     
==========================================
  Files          19       19              
  Lines        3232     3233       +1     
==========================================
+ Hits         1057     1060       +3     
+ Misses       2115     2114       -1     
+ Partials       60       59       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit db14d1b into OT-CONTAINER-KIT:master Feb 20, 2024
30 of 31 checks passed
@drivebyer drivebyer deleted the log-enhance branch February 20, 2024 06:20
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Creating redis cluster by executing cluster creation commands" log line is redundand and misleading
2 participants