Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added namespace to tls configuration #763

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egorksv
Copy link

@egorksv egorksv commented Jan 30, 2024

Description

Changed podName to podName.namespace in redis-client config so that is it possible to issue *.namespace wildcard TLS certificate with cert-manager

Fixes #447

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

@egorksv egorksv force-pushed the fix/tls-client-hostname branch from 14290db to 642f4c0 Compare January 30, 2024 22:53
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e6fcb9) 32.79% compared to head (642f4c0) 32.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   32.79%   32.79%           
=======================================
  Files          19       19           
  Lines        3232     3232           
=======================================
  Hits         1060     1060           
  Misses       2113     2113           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer
Copy link
Collaborator

drivebyer commented May 22, 2024

Does this change break compatibility with the old certificate? @egorksv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using TLS, the operator cannot reconcile because TLS does not sign the pod name
2 participants