test: add envtest for redis standalone

[MathieuCesbron]

Description

I feel like it would be a good idea to add integration tests with EnvTest on the reconcile loop like mentioned here.

Would this feature be accepted if I make it ?

Edit: Feature accepted

Fixes #656

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist

• Tests have been added/modified and all tests pass.
• Functionality/bugs have been confirmed to be unchanged or fixed.
• I have performed a self-review of my own code.
• Documentation has been updated or added where necessary.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7665d4a) 29.25% compared to head (0935e54) 29.89%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   29.25%   29.89%   +0.64%     
==========================================
  Files          19       19              
  Lines        3241     3241              
==========================================
+ Hits          948      969      +21     
+ Misses       2258     2233      -25     
- Partials       35       39       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[drivebyer]

Actually, we use chainsaw to do some e2e test, plz see https://github.com/OT-CONTAINER-KIT/redis-operator/tree/master/tests/e2e-chainsaw/v1beta2. :)

[MathieuCesbron]

So you think there is no point in doing integration test ? e2e is enough ?

I like integration tests because it's fast to run while still testing the reconcile logic in an holistic way.

[drivebyer]

So you think there is no point in doing integration test ? e2e is enough ?

I like integration tests because it's fast to run while still testing the reconcile logic in an holistic way.

Integration tests is nice of course.

[MathieuCesbron]

Thanks for your input.

I asked because I would like to know if I should start the feature or if it's not gonna be accepted anyway.

[drivebyer]

Thanks for your input.

I asked because I would like to know if I should start the feature or if it's not gonna be accepted anyway.

IMO, it's a nice feature for the operator.

cc @shubham-cmyk

[shubham-cmyk]

Integration testing is great you can add that👌

[MathieuCesbron]

I have added the setup for integration test and integration tests for redis standalone. We check that statefulset, service,... are created and that deleting the CR delete the statefulset.

I will add integration tests for the other redis (cluster, replication, sentinel) each in his own PR if you don't mind.

The code coverage is now 29.89% 🥳

[drivebyer]

nice work!