Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ENABLE_WEBHOOKS env which cloud disable webhook server locally #617

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Support ENABLE_WEBHOOKS env which cloud disable webhook server locally #617

merged 2 commits into from
Sep 11, 2023

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Sep 10, 2023 •
edited
Loading

Description

When run operator locally, we may not use webhook server usaually, then we can provide option to disable webhook server, just like: kubernetes-sigs/controller-runtime#491 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

shubham-cmyk
shubham-cmyk reviewed Sep 10, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
@drivebyer
Copy link
Collaborator Author

BTW, I found these:

  1. https://github.com/OpenFunction/OpenFunction/blob/92fe37b7b6f4b4e9d75f2e2cca050958787a5f99/main.go#L185-L202
  2. https://github.com/apache/skywalking-swck/blob/fd6f354bf8af88d0196d02ff5ca2b8be41a847b1/operator/main.go#L171
  3. https://github.com/open-telemetry/opentelemetry-operator/blob/main/main.go#L246

@drivebyer
Add related flag
3d5a67f 
Signed-off-by: drivebyer <[email protected]>
shubham-cmyk
shubham-cmyk approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shubham-cmyk shubham-cmyk merged commit 71ef65b into OT-CONTAINER-KIT:master Sep 11, 2023
@drivebyer drivebyer deleted the disable-webhook-option branch September 11, 2023 08:07
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@drivebyer @mattrobinsonsre
Support ENABLE_WEBHOOKS env which cloud disable webhook server locally (
0ca71da 
OT-CONTAINER-KIT#617)

* Support ENABLE_WEBHOOKS env which cloud disable webhook server on locally

Signed-off-by: drivebyer <[email protected]>

* Add related flag

Signed-off-by: drivebyer <[email protected]>

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drivebyer @shubham-cmyk