[feature]add serviceType #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yanru.lv <[email protected]>
Signed-off-by: yanru.lv <[email protected]>
iamabhishek-dubey
requested changes
Nov 14, 2022
Signed-off-by: yanru.lv <[email protected]>
iamabhishek-dubey
requested changes
Nov 14, 2022
k8sutils/redis-cluster.go
Outdated
| if cr.Spec.RedisExporter != nil && cr.Spec.RedisExporter.Enabled { | ||
| enableMetrics = true | ||
| } | ||
| objectMetaInfo := generateObjectMetaInformation(serviceName, cr.Namespace, labels, annotations) | ||
| headlessObjectMetaInfo := generateObjectMetaInformation(serviceName+"-headless", cr.Namespace, labels, annotations) | ||
| err := CreateOrUpdateService(cr.Namespace, headlessObjectMetaInfo, redisClusterAsOwner(cr), false, true) | ||
| err := CreateOrUpdateService(cr.Namespace, headlessObjectMetaInfo, redisClusterAsOwner(cr), false, true, cr.Spec.KubernetesConfig.Service.ServiceType) |
There was a problem hiding this comment.
One more suggestion, I think we should not overwrite the existing headless service because this might be useful for internal communication without load-balancing. I would suggest creating another service in parallel with the defined service type and let's call it additional-service. In this way, we can also remove the service creation logic from the helm chart.
Signed-off-by: yanru.lv <[email protected]>
|
@iamabhishek-dubey |
|
Any movement on pushing a new release plan? |
devkmsg
added a commit
to devkmsg/redis-operator
that referenced
this pull request
Mar 7, 2023
…HOMPSON/redis-operator:sync-upstream-0.14 to master Auto-Merge: Pull request OT-CONTAINER-KIT#11: [AUTO] Sync upstream @ v0.14 Merge in OSS/redis-operator from ~ATHOMPSON/redis-operatorsync-upstream-0.14 to master * commit 'e86884ead1005484bdb10fb30caf8f8acac2f89b': (49 commits) [Feature] Add Redis Sentinel Support (OT-CONTAINER-KIT#408) Fixed Redis Replicate Cache bug (OT-CONTAINER-KIT#424) [Feature] : Add Replication Mode to the Redis Operator (OT-CONTAINER-KIT#417) [Development][Add] Added recreation logic for statefulset (OT-CONTAINER-KIT#411) Fixes issue with arm64 support. (OT-CONTAINER-KIT#404) [Development][Add] Added nodeSelector and tolerations for cluster (OT-CONTAINER-KIT#410) Add Label Selector to pod anti affinity (OT-CONTAINER-KIT#407) When cr annotation update,sts annotations will not updated! (OT-CONTAINER-KIT#398) fix: invalid memory address or nil pointer dereference (OT-CONTAINER-KIT#395) export redis exporter as a container port (OT-CONTAINER-KIT#393) [Development][Add] Added feature for additional volume mounts (OT-CONTAINER-KIT#389) fix crash with go panic (OT-CONTAINER-KIT#385) Add check PersistenceEnabled not nil (OT-CONTAINER-KIT#380) [feature]add serviceType functionality for standalone and cluster with annotations (OT-CONTAINER-KIT#376) [Development][Update]Updated information for v0.13.0 (OT-CONTAINER-KIT#374) Create CODE_OF_CONDUCT.md [feature]add tls for redis-standlone (OT-CONTAINER-KIT#372) Update README.md Create package.json Revamped documentation for better knowledge base (OT-CONTAINER-KIT#370) ...
devkmsg
added a commit
to devkmsg/redis-operator
that referenced
this pull request
Jan 30, 2024
…/internal patches Merge in OSS/redis-operator from ~ATHOMPSON/redis-operator:sync-internal-cs-main-to-0.14 to cs-main * commit '2ea8fcaf61b322186f8a0a2c4e7bcb310f55ea2d': Revert "Handle nil probe" Handle nil probe Bumps prometheus/client_golang to address vuln Adds CODEOWNERS for our internal branch [Feature] Add Redis Sentinel Support (OT-CONTAINER-KIT#408) Fixed Redis Replicate Cache bug (OT-CONTAINER-KIT#424) [Feature] : Add Replication Mode to the Redis Operator (OT-CONTAINER-KIT#417) [Development][Add] Added recreation logic for statefulset (OT-CONTAINER-KIT#411) Fixes issue with arm64 support. (OT-CONTAINER-KIT#404) [Development][Add] Added nodeSelector and tolerations for cluster (OT-CONTAINER-KIT#410) Add Label Selector to pod anti affinity (OT-CONTAINER-KIT#407) When cr annotation update,sts annotations will not updated! (OT-CONTAINER-KIT#398) fix: invalid memory address or nil pointer dereference (OT-CONTAINER-KIT#395) export redis exporter as a container port (OT-CONTAINER-KIT#393) [Development][Add] Added feature for additional volume mounts (OT-CONTAINER-KIT#389) fix crash with go panic (OT-CONTAINER-KIT#385) Add check PersistenceEnabled not nil (OT-CONTAINER-KIT#380) [feature]add serviceType functionality for standalone and cluster with annotations (OT-CONTAINER-KIT#376)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yanru.lv [email protected]
Description
add serviceType for redis-standlone/cluster
Fixes #ISSUE
#317
Type of change
/kind feature
Checklist