Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let lost follower join cluster #361

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Oct 27, 2022

Fix this:

When we have:

  • leader: [xxx-leader-0, xxx-leader-1, xxx-leader-2]
  • follower: [xxx-follower-0, xxx-follower-1, xxx-follower-2, xxx-follower-3, xxx-follower-4, xxx-follower-5]

[xxx-follower-3, xxx-follower-4, xxx-follower-5] can not join cluster.

@drivebyer
Copy link
Collaborator Author

PTAL @iamabhishek-dubey

@drivebyer drivebyer force-pushed the fix-replication-in-cluster-mode branch from ca1ee12 to 4ed68a7 Compare October 27, 2022 05:38
@iamabhishek-dubey iamabhishek-dubey added the enhancement New feature or request label Oct 27, 2022
@iamabhishek-dubey iamabhishek-dubey merged commit dc07470 into OT-CONTAINER-KIT:master Oct 27, 2022
@drivebyer drivebyer deleted the fix-replication-in-cluster-mode branch October 27, 2022 06:59
@drivebyer drivebyer changed the title fix: lost replications when followerReplicas bigger than leaderReplicas feat: let lost follower join cluster Oct 27, 2022
devkmsg added a commit to devkmsg/redis-operator that referenced this pull request Jan 30, 2024
… v0.13.0

Merge in OSS/redis-operator from ~ATHOMPSON/redis-operator:sync-upstream-0.13 to cs-main

* commit '4e0dafa8227f0ed1ff9966000a477c29fa99af57': (38 commits)
  Handle nil probe
  Bumps prometheus/client_golang to address vuln
  Adds CODEOWNERS for our internal branch
  [Development][Update]Updated information for v0.13.0 (OT-CONTAINER-KIT#374)
  Create CODE_OF_CONDUCT.md
  [feature]add tls for redis-standlone (OT-CONTAINER-KIT#372)
  Update README.md
  Create package.json
  Revamped documentation for better knowledge base (OT-CONTAINER-KIT#370)
  [Development][Change] Change ctrl time for errors (OT-CONTAINER-KIT#369)
  Added logic for updating followers replicas (OT-CONTAINER-KIT#367)
  Updated the security context for controller manager (OT-CONTAINER-KIT#366)
  Renamed the external config to additional config (OT-CONTAINER-KIT#365)
  fix: lost replications when followerReplicas bigger than leaderReplicas (OT-CONTAINER-KIT#361)
  [Development][Add] Added update strategy for statefulset (OT-CONTAINER-KIT#358)
  Update pipeline.yaml
  Added build arg for arm64 support (OT-CONTAINER-KIT#356)
  [Development][Add] Added option to pause reconcilations (OT-CONTAINER-KIT#353)
  Changed publish branch
  Removed docs from path of build
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants