Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce the impact of Redis cluster intermediate states #1178

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

xiaozhuang-a
Copy link
Contributor

Description

ensure that clusterSize and statefulset are consistent

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 30.02%. Comparing base (60ef5a2) to head (fc8e3e6).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...ontrollers/rediscluster/rediscluster_controller.go 0.00% 26 Missing and 1 partial ⚠️
pkg/k8sutils/statefulset.go 0.00% 9 Missing ⚠️
pkg/k8sutils/cluster-scaling.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
- Coverage   30.20%   30.02%   -0.18%     
==========================================
  Files          55       55              
  Lines        6294     6411     +117     
==========================================
+ Hits         1901     1925      +24     
- Misses       4200     4287      +87     
- Partials      193      199       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer enabled auto-merge (squash) December 21, 2024 05:55
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit 1db22ae into OT-CONTAINER-KIT:master Dec 21, 2024
17 of 19 checks passed
@xiaozhuang-a xiaozhuang-a deleted the fix-downScaling2 branch December 23, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants