feat: support PDB in redisreplication #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Husni Alhamdani <[email protected]>
drivebyer
requested review from
shubham-cmyk,
drivebyer and
iamabhishek-dubey
as code owners
Signed-off-by: yangw <[email protected]>
… consistency Updated the function name from GetPodDisruptionBudget to getPodDisruptionBudget across multiple locations in poddisruption.go to follow Go naming conventions and improve code consistency. This change affects the reconciliation functions for Redis, Sentinel, and Replication Pod Disruption Budgets. Signed-off-by: yangw <[email protected]>
xiaozhuang-a
pushed a commit
to xiaozhuang-a/redis-operator
that referenced
this pull request
Dec 18, 2024
<!-- Please read https://github.com/OT-CONTAINER-KIT/redis-operator/blob/master/CONTRIBUTING.md before submitting your pull request. Please fill in each section below to help us better prioritize your pull request. Thanks! --> **Description** <!-- Please provide a summary of the change here. --> Support PDB in redisreplication **Type of change** <!-- Please delete options that are not relevant. --> * Bug fix (non-breaking change which fixes an issue) * New feature (non-breaking change which adds functionality) * Breaking change (fix or feature that would cause existing functionality to not work as expected) **Checklist** - [ ] Tests have been added/modified and all tests pass. - [ ] Functionality/bugs have been confirmed to be unchanged or fixed. - [x] I have performed a self-review of my own code. - [ ] Documentation has been updated or added where necessary. **Additional Context** <!-- Is there anything else you'd like reviewers to know? For example, any other related issues or testing carried out. --> Signed-off-by: xiaozhuang <[email protected]>
xiaozhuang-a
pushed a commit
to xiaozhuang-a/redis-operator
that referenced
this pull request
Dec 18, 2024
<!-- Please read https://github.com/OT-CONTAINER-KIT/redis-operator/blob/master/CONTRIBUTING.md before submitting your pull request. Please fill in each section below to help us better prioritize your pull request. Thanks! --> **Description** <!-- Please provide a summary of the change here. --> Support PDB in redisreplication **Type of change** <!-- Please delete options that are not relevant. --> * Bug fix (non-breaking change which fixes an issue) * New feature (non-breaking change which adds functionality) * Breaking change (fix or feature that would cause existing functionality to not work as expected) **Checklist** - [ ] Tests have been added/modified and all tests pass. - [ ] Functionality/bugs have been confirmed to be unchanged or fixed. - [x] I have performed a self-review of my own code. - [ ] Documentation has been updated or added where necessary. **Additional Context** <!-- Is there anything else you'd like reviewers to know? For example, any other related issues or testing carried out. --> Signed-off-by: xiaozhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support PDB in redisreplication
Type of change
Checklist
Additional Context