Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context param and get logger from it #1132

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

drivebyer
Copy link
Collaborator

Description

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer added the enhancement New feature or request label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 21.48014% with 435 lines in your changes missing coverage. Please review.

Project coverage is 29.95%. Comparing base (d121d86) to head (95256a7).
Report is 137 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sutils/redis.go 32.00% 85 Missing ⚠️
pkg/k8sutils/cluster-scaling.go 9.30% 78 Missing ⚠️
...ontrollers/rediscluster/rediscluster_controller.go 10.14% 60 Missing and 2 partials ⚠️
pkg/k8sutils/poddisruption.go 0.00% 36 Missing ⚠️
pkg/k8sutils/redis-cluster.go 6.89% 27 Missing ⚠️
pkg/k8sutils/redis-sentinel.go 21.87% 25 Missing ⚠️
...rs/redisreplication/redisreplication_controller.go 20.00% 19 Missing and 1 partial ⚠️
pkg/k8sutils/redis-replication.go 0.00% 17 Missing ⚠️
pkg/k8sutils/statefulset.go 53.33% 14 Missing ⚠️
pkg/k8sutils/services.go 42.85% 12 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
- Coverage   35.20%   29.95%   -5.25%     
==========================================
  Files          19       54      +35     
  Lines        3213     6243    +3030     
==========================================
+ Hits         1131     1870     +739     
- Misses       2015     4182    +2167     
- Partials       67      191     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit 3135e0f into OT-CONTAINER-KIT:master Nov 15, 2024
16 of 19 checks passed
@drivebyer drivebyer deleted the logger branch November 28, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant