Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reconcile redissentinel only on master changed #1122

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Nov 6, 2024

Description

Fixes #1094 #802

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer added the enhancement New feature or request label Nov 6, 2024
Signed-off-by: drivebyer <[email protected]>
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.23%. Comparing base (d121d86) to head (87badb8).
Report is 128 commits behind head on master.

Files with missing lines Patch % Lines
...trollers/redissentinel/redissentinel_controller.go 16.66% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
+ Coverage   35.20%   44.23%   +9.02%     
==========================================
  Files          19       20       +1     
  Lines        3213     3423     +210     
==========================================
+ Hits         1131     1514     +383     
+ Misses       2015     1822     -193     
- Partials       67       87      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: drivebyer <[email protected]>
Copy link

gitguardian bot commented Nov 6, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5685959 Triggered Generic Password 87badb8 tests/e2e-chainsaw/v1beta2/setup/ha/sentinel-password/secret.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@drivebyer drivebyer merged commit c48c9c5 into OT-CONTAINER-KIT:master Nov 6, 2024
18 of 19 checks passed
@drivebyer drivebyer deleted the masterchange branch November 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With automatic master failover in RedisReplication using Redis Sentinel (delete master)
1 participant