Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing custom metadata to redis pods #95

Closed
oliveratprimer opened this issue Jun 11, 2021 · 6 comments · Fixed by #193
Closed

Passing custom metadata to redis pods #95

oliveratprimer opened this issue Jun 11, 2021 · 6 comments · Fixed by #193
Labels
good first issue Good for newcomers

Comments

@oliveratprimer
Copy link

What would be the right way to pass custom labels and annotations to redis pods? Adding them to the metadata section in the manifest seems to only add it to the redis object and not the pod.

@iamabhishek-dubey iamabhishek-dubey added the good first issue Good for newcomers label Jun 12, 2021
@fabio-pardo
Copy link

fabio-pardo commented Aug 20, 2021

Is there an update with this?

@davidcollom
Copy link
Contributor

Seams a reasonable ask.

What would your expected API Look like for a Redis/RedisCluster Resource?

apiVersion: redis.redis.opstreelabs.in/v1beta1
kind: RedisCluster
metadata:
  name: redis-cluster
spec:
  clusterSize: 3
  [...SNIP...]
  labels:
    labelkey: value
  annotations:
    annotations: value

Or were you thinking something a little more simplistic in that all labels/annotations from the Redis/RedisCluster resource are reflected on the Statefulset/Pods:

apiVersion: redis.redis.opstreelabs.in/v1beta1
kind: RedisCluster
metadata:
  name: redis-cluster
  labels:
    labelkey: labelvalue
  annotations:
    annotation: value
spec:
  clusterSize: 3
  [...SNIP...]

@oliveratprimer
Copy link
Author

@davidcollom ideally all pods and storages that are created by it to inherit the redis cluster metadata (labels and annotations).

I do think some people might want to be able to pass custom labels to both but unsure how many times it has been requested.

Thank you in advance

@davidcollom
Copy link
Contributor

Cool, so the latter example... Let me have a see what I can do.. 😉

@skaugvoll
Copy link

Hi @davidcollom, any progress on this ?
It would be really nice to have the ability to set annotations on the statefulsets/pods, such as shown in the second example shown above

@davidcollom
Copy link
Contributor

Hi @skaugvoll Sorry, my workload has just increased ten fold since my response in Sept - I may have some downtime during the holiday period to implement the feature.

davidcollom added a commit to davidcollom/redis-operator that referenced this issue Dec 31, 2021
iamabhishek-dubey pushed a commit that referenced this issue Jan 10, 2022
* Initial working for issue #95

Signed-off-by: David Collom <[email protected]>

* Fix up annotations continously changing

Signed-off-by: David Collom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants