-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing custom metadata to redis pods #95
Comments
Is there an update with this? |
Seams a reasonable ask. What would your expected API Look like for a Redis/RedisCluster Resource? apiVersion: redis.redis.opstreelabs.in/v1beta1
kind: RedisCluster
metadata:
name: redis-cluster
spec:
clusterSize: 3
[...SNIP...]
labels:
labelkey: value
annotations:
annotations: value Or were you thinking something a little more simplistic in that all labels/annotations from the Redis/RedisCluster resource are reflected on the Statefulset/Pods: apiVersion: redis.redis.opstreelabs.in/v1beta1
kind: RedisCluster
metadata:
name: redis-cluster
labels:
labelkey: labelvalue
annotations:
annotation: value
spec:
clusterSize: 3
[...SNIP...] |
@davidcollom ideally all pods and storages that are created by it to inherit the redis cluster metadata (labels and annotations). I do think some people might want to be able to pass custom labels to both but unsure how many times it has been requested. Thank you in advance |
Cool, so the latter example... Let me have a see what I can do.. 😉 |
Hi @davidcollom, any progress on this ? |
Hi @skaugvoll Sorry, my workload has just increased ten fold since my response in Sept - I may have some downtime during the holiday period to implement the feature. |
Signed-off-by: David Collom <[email protected]>
* Initial working for issue #95 Signed-off-by: David Collom <[email protected]> * Fix up annotations continously changing Signed-off-by: David Collom <[email protected]>
What would be the right way to pass custom labels and annotations to redis pods? Adding them to the metadata section in the manifest seems to only add it to the redis object and not the pod.
The text was updated successfully, but these errors were encountered: