Ecsv and colors as dictionary and look up list. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a parametric model
… some helpers functions a func.py library, improved some comments, moved to using rebound to compute true anomally
Updated the version on CANFAR arc before doing a pull.
make a run pipe instead of multiple run commands.
…nary and use 'ECSV' as the file save format.
Also improved the documentation.
This commit also moved some code around to improve the flow of the file, but we should split some of this code into separate files.
…h call to simulate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major change is in the use of ECSV file to store model results. This allows a very rich header that fully describes the simulation file and allows them to be read by standard table readers in astropy, topcat and pandas.
On the FORTRAN side, the color array has been changed so that the index in the of the color term is determined not by a fixed order but by the ASCII code of the band pass letter, minus ASCII(A). i.e. for a FILTER named 'A' the color term is looked for in element 1 of the color array while for filter 'g' we look in element 39. For this to work the 'detec1' subroutine is passed a color array that is at least 58 elements long (ascii(z) - ascii(A) + 1).