Changed test file name from .permission_test to UUID to make it thread safe #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## dev #1110 +/- ##
==========================================
- Coverage 80.71% 80.12% -0.59%
==========================================
Files 67 5 -62
Lines 6056 468 -5588
==========================================
- Hits 4888 375 -4513
+ Misses 1168 93 -1075
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lsetiawan
approved these changes
Aug 3, 2023
|
Hey @Sohambutala : Thanks for changing this! For the sake of documentation, could you edit the PR comment to put in short explanation on why this change is needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @lsetiawan, for this suggestion!
The previous method of verifying necessary permissions in the output folder involved the creation of a temporary file named ".permission_test." However, when dealing with multiple threads in a multithreading scenario, simultaneous attempts by these threads to create, delete, or modify the same file led to a "FileNotFoundError." To address this issue, we've implemented a solution where a unique UUID is now used as the filename instead of a constant name. This way, each file works with its own individual temporary file to verify the required permissions.