-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AZFP: add missing mandatory Beam_group1 variables #1102
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1102 +/- ##
==========================================
- Coverage 78.15% 77.65% -0.50%
==========================================
Files 65 18 -47
Lines 6234 2927 -3307
==========================================
- Hits 4872 2273 -2599
+ Misses 1362 654 -708
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 49 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Added |
"long_name": "Type of transmitted pulse", | ||
"flag_values": ["CW"], | ||
"flag_meanings": [ | ||
"Continuous Wave", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been mulling over about this. It is true that CW is Continuous Wave, but it is an approximation. The actual transmit signal is gated sine wave. I wonder if this would be misleading. This is something defined in the convention, but do you think we can add something to make it "Continuous Wave (gated sine wave)"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only have a small comment on one of the flag_meanings
.
We've discussed the |
Addresses #1100