Remove preprocess from subpackages to test in run-test [all tests ci]

[emiliom]

See #1076.

[lsetiawan]

This is great! I'm glad it's pretty straightforward. I am wondering however, has this submodule been removed? The main CI do run all the tests using pytest directly rather than using the run-test.py script. See https://github.com/OSOceanAcoustics/echopype/blob/dev/.github/workflows/build.yaml#L80

[emiliom]

The preprocess subpackage is not removed. All the preprocess tests were removed back when preprocess was deprecated.

run-test.py is still being used in pr.yml:

echopype/.github/workflows/pr.yaml

Lines 89 to 93 in e11c665

	- name: Running Tests
	if: "!contains(github.event.pull_request.title, '[all tests ci]')"
	shell: bash -l {0}
	run: |
	python .ci_helpers/run-test.py --pytest-args="--log-cli-level=WARNING,-vvv,-rx,--numprocesses=${{ env.NUM_WORKERS }},--max-worker-restart=3,--disable-warnings" --include-cov ${{ steps.files.outputs.added_modified_renamed }} |& tee ci_test_log.log

Am I missing something?

[emiliom]

BTW, I forgot to use "[all tests ci]" in the PR title, so it looks like most of the tests didn't run here. I added it after the fact here, but it looks like a title edit doesn't spawn a re-run of tests.

[lsetiawan]

BTW, I forgot to use "[all tests ci]" in the PR title, so it looks like most of the tests didn't run here. I added it after the fact here, but it looks like a title edit doesn't spawn a re-run of tests.

Yea, I haven't found a way to trigger actions when changing the title, but closing and opening seem to always, work and that's what I did. Seems like now the proper action step is running.

[emiliom]

Yea, I haven't found a way to trigger actions when changing the title, but closing and opening seem to always, work and that's what I did. Seems like now the proper action step is running.

Oooh, great trick, thanks! I'll remember that.

[codecov-commenter]

Codecov Report

Merging #1077 (0831ec8) into dev (e11c665) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1077      +/-   ##
==========================================
+ Coverage   77.67%   77.71%   +0.03%     
==========================================
  Files          67       67              
  Lines        6249     6254       +5     
==========================================
+ Hits         4854     4860       +6     
+ Misses       1395     1394       -1     

Flag	Coverage Δ
unittests	77.71% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more