-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some Vendor-specific group attributes to data variables #1075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Things are so nice and simple when you don't have to worry about having variable attributes 😆 . I like how you organized the variable assignments into blocks with a helpful but brief comment line.
Just one question: I assume that these changes have no downstream effect on calibration functions, since there are no changes to that code?
Oh right, this completely slipped my mind. The ones that I can think of on top of my head are the conversion for temperature and tilt_x/tilt_y, from the raw count combining with the coefficients in the variables ( |
Ok, confirmed -- none of the attributes that I moved to be data variables are used in later calculations. :) |
…Acoustics#1075) * change EK80 xml in vendor group to be variable instead of attribute * move azfp vendor attrs to variables * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove noqa * add back accidentally removed , --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This PR moves some Vendor-specific group attributes to data variables to make it more efficient to lazy-load and combine echodata objects, and potentially on the writing speed to cloud. This addresses #1055 and potentially #640 (AZFP) and #1045 (though the goal changed, EK80).
The changes include:
xml_config
which is the entire XML string from an attribute to a data variableI've tested
combine_echodata
with the new format and these are combined correctly -- that all these variables remain data variables without a dimension (constants). The combine would error out if any of these variables change across the echodata objects to be combined, which is the desired behavior since those echodata objects should not be combined.