Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHPOpenLL(): avoid GDAL specific error message when .shx is missing #130

Merged
merged 1 commit into from
May 29, 2024
Merged

SHPOpenLL(): avoid GDAL specific error message when .shx is missing #130

merged 1 commit into from
May 29, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented May 29, 2024

Fixes #129

thbeu
thbeu reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@thbeu thbeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to avoid the trailing blank.

shpopen.c Outdated Show resolved Hide resolved
shpopen.c Outdated Show resolved Hide resolved
rouault added a commit to rouault/gdal that referenced this pull request May 29, 2024
@rouault
Shapelib: resync with OSGeo/shapelib#130
12d74a5
rouault added a commit to rouault/gdal that referenced this pull request May 29, 2024
@rouault
Shapelib: resync with OSGeo/shapelib#130
a9efc21
thbeu
thbeu reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@thbeu thbeu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify: Gdal does not need to change its build. But other distributors should define SHP_RESTORE_SHX_HINT_MESSAGE at build time.

Edit: SHPRestoreSHX is a library method, thus not GDAL specific.

rouault added a commit to rouault/gdal that referenced this pull request May 29, 2024
@rouault
Shapelib: resync with OSGeo/shapelib#130
279190a
thbeu
thbeu reviewed May 29, 2024
View reviewed changes
shpopen.c Outdated Show resolved Hide resolved
rouault added a commit to rouault/gdal that referenced this pull request May 29, 2024
@rouault
Shapelib: resync with OSGeo/shapelib#130
f706976
@rouault rouault merged commit 011083c into OSGeo:master May 29, 2024
6 checks passed
@thbeu
Copy link
Contributor

thbeu commented May 29, 2024

Thanks for the fast fix. 🚀

rouault added a commit to OSGeo/gdal that referenced this pull request May 29, 2024
@rouault
Merge pull request #10063 from rouault/shapelib_pr_130
3041877 
Shapelib: resync with OSGeo/shapelib#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbeu thbeu thbeu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear SHAPE_RESTORE_SHX config option
2 participants
@rouault @thbeu