Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS driver update #8646

Merged
merged 3 commits into from
Nov 2, 2023
Merged

NAS driver update #8646

merged 3 commits into from
Nov 2, 2023

Conversation

jef-n
Copy link
Contributor

@jef-n jef-n commented Nov 1, 2023

No description provided.

@rouault
Copy link
Member

rouault commented Nov 1, 2023

Failure on MacOS build should be fixed per e4026b0

@rouault
Copy link
Member

rouault commented Nov 1, 2023

clang static analyzer:

{
  "uri": "file:///home/runner/work/gdal/gdal/ogr/ogrsf_frmts/nas/nashandler.cpp",
  "msg": "Value stored to 'pszName' during its initialization is never read",
  "location": {
    "importance": "essential",
    "location": {
      "message": {
        "text": "Value stored to 'pszName' during its initialization is never read"
      },
      "physicalLocation": {
        "artifactLocation": {
          "fileIndex": 0,
          "uri": "file:///home/runner/work/gdal/gdal/ogr/ogrsf_frmts/nas/nashandler.cpp"
        },
        "region": {
          "endColumn": 25,
          "endLine": 464,
          "startColumn": 25,
          "startLine": 464
        }
      }
    }
  }
}

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 67.886% (+0.02%) from 67.864% when pulling 903eaf3 on jef-n:gid7-fffix into e4026b0 on OSGeo:master.

@rouault rouault added this to the 3.8.0 milestone Nov 1, 2023
@rouault
Copy link
Member

rouault commented Nov 2, 2023

@jef-n Has this sufficiently been tested to be included in 3.8.0 ?

@jef-n
Copy link
Contributor Author

jef-n commented Nov 2, 2023

@jef-n Has this sufficiently been tested to be included in 3.8.0 ?

I think so. I verified that it produces identical results using old data and it works with new test data - but there's no real data yet and there will be a hard switch beginning next year in most German states (GeoInfoDok 6.0.1 => 7.1.2).

@rouault
Copy link
Member

rouault commented Nov 2, 2023

ok, thanks. merging

@rouault rouault merged commit a963578 into OSGeo:master Nov 2, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants