Ticket #5357: New OGR_G_SetPointCount and OGR_G_SetPoints functions in API C

[ahuarte47]

New functions:

• void CPL_DLL OGR_G_SetPointCount( OGRGeometryH hGeom, int nNewPointCount );
• void CPL_DLL OGR_G_SetPoints( OGRGeometryH hGeom, ... );

[rouault]

This does not compile. Extract from Travis log :

�[1mogr_api.cpp:87:54: �[0m�[0;1;31merror: �[0m�[1mtoo many arguments provided to function-like macro
invocation�[0m
VALIDATE_POINTER0( hGeom, "OGR_G_SetPointCount", 0 );
�[0;1;32m ^
�[0m�[1m/home/travis/build/OSGeo/gdal/gdal/port/cpl_error.h:100:9: �[0m�[0;1;30mnote: �[0mmacro
'VALIDATE_POINTER0' defined here�[0m
#define VALIDATE_POINTER0(ptr, func)
�[0;1;32m ^
�[0m�[1mogr_api.cpp:87:5: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier 'VALIDATE_POINTER0'�[0m
VALIDATE_POINTER0( hGeom, "OGR_G_SetPointCount", 0 );
�[0;1;32m ^
�[0m2 errors generated.

Is there an interest in OGR_G_SetPointCount() since OGR_G_SetPoints() will also call it ? Out of curiostiy, what is the use case for this patch ?

[ahuarte47]

Hi @rouault; I "need" one of these functions to enable in QGIS the simplification of geometries in OGR-provider to speed up the rendering of features.

See...
qgis/QGIS#1087 (comment)

Now, QGIS simplifies the geometries fetched from provider, but in OGR-provider we can not use a pre-simplification of the OgrGeometry because GDAL API C has not published one of these functions.

[rouault]

Patch commited in trunk

[ahuarte47]

Thank you very much! @rouault

[ahuarte47]

Hi @rouault, these functions in what release will are published ? 1.11 release ?

Thanks in advance

[rouault]

The next major release. 1.11 or 2.0, it hasn't really been decided yet how it will be named. It depends on the amount of backward incompatibility introduced

[ahuarte47]

Thanks, then can I use ....

#if defined(GDAL_VERSION_NUM) && defined(GDAL_COMPUTE_VERSION) && GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(1,11,0)

?

[rouault]

yes, that will work

[ahuarte47]

Thank you very much