projCtx_t: Copy ini file settings, proj4_init_rules, etc.. when initializing context from global #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowman2
force-pushed
the
ctx_proj4_init
branch
3 times, most recently
from
a6b62e1 to
eb040aa
Compare
…alizing context from global
snowman2
force-pushed
the
ctx_proj4_init
branch
from
eb040aa to
b095cf8
Compare
rouault
reviewed
Aug 20, 2020
Co-authored-by: Even Rouault <[email protected]>
snowman2
force-pushed
the
ctx_proj4_init
branch
from
6a0c253 to
12143d3
Compare
|
Should I also copy |
This is not necessary. This variable is only transiently set to true at https://github.com/OSGeo/PROJ/blob/master/src/iso19111/c_api.cpp#L186 (you may add a comment about that) |
There is a comment |
Maybe "// set transiently by pj_obj_create()" ? |
|
Thanks for the review @rouault. Very helpful 👍 |
This was referenced Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a couple of other settings that weren't copied from the global context. I figured initializing them here might reduce the overhead of loading in of the data elsewhere when creating new contexts. Thoughts?