-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGR: 7.2.1+ ~20x slower than past versions. #2734
Comments
There is likely a missing element in the scenario you mention. If I run the following snippet, proj.db is not opened at all and it runs in 1.2 second (so ~ 0.1 ms per call)
I tried with "EPSG:4326" as a string and it is much slower of course (~ 45 s for 10,000 iterations), but there is no significant difference if running checkDatabaseLayout() or not. |
I am assuming this is with PROJ 7.2.1+. How fast is it with PROJ 7.2.0? |
I tested with 7.2.0, the head of 7.2 branch (~ 7.2.1) and master. proj.db isn't opened at all, so #2474 is not relevant |
Sounds like I may have made a mistake with the bisect. Feel free to re-do it and see what you find. |
I will not find anything since I have the same performance for all versions :-) I guess your use in pyproj must do something in addition to your pseudo code |
Ah, that makes sense. These would be the lines
|
It also calls |
That's the key to reproduce: it does indeed cause a connection opening later in the calls done by proj_create() |
…f proj_context_set_autoclose_database() has been set (fixes OSGeo#2734)
Thanks @rouault 👍 |
Is this regression fixed in PyProj>=3.2.1? I haven't been able to use PyProj>=3.0.1 for months because of this serious performance problem. I can't exactly tell from the history on this thread. |
Should be. Have you tried it out yet to verify? |
From: pyproj4/pyproj#827
Example of problem
psedo code:
Problem description
In PROJ<=7.2.0 appears to be ~20x faster than PROJ 7.2.1+. Based on a git bisect, the performance change appears in #2474.
Environment Information
Installation method
The text was updated successfully, but these errors were encountered: