Move output setting to device table #974
Open
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jasper Kamerling <[email protected]>
|
SonarCloud Quality Gate failed. |
smvdheijden
requested changes
Jan 30, 2023
Comment on lines
+103
to
+111
| /** | ||
| * The output settings are only used in the ssld table but in the database it is linked to the | ||
| * Device Table. | ||
| */ | ||
| @LazyCollection(LazyCollectionOption.FALSE) | ||
| @ElementCollection() | ||
| @CollectionTable(name = "device_output_setting", joinColumns = @JoinColumn(name = "device_id")) | ||
| protected List<DeviceOutputSetting> outputSettings = new ArrayList<>(); | ||
|
|
There was a problem hiding this comment.
I prefer not to have an SSLD specific field in the generic device Entitiy. It would probably be better to change the relationship in the DB and change the foreign key to point to the ssld id (which should effectively be the same as the device id due to the inheritance relation between them)?
There was a problem hiding this comment.
True that would be better but that would be a big change in the data model.
This just fixes the application issues with the data model.
There was a problem hiding this comment.
I don't think a big change in the data model is needed. Setting ON DELETE CASCADE will probably also work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database doesn't match the JPA model that was created. This may cause issues when deleting ssld's or devices.
The real solution would be to refactor the database but this is a first step to have the jpa model match the database.