Feature/smhe 1740 config service test alarm scheduler command executor #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w.i.p. use config service in TestAlarmSchedulerCommandExecutor Signed-off-by: Natasja <[email protected]>
use config service in TestAlarmSchedulerCommandExecutor Signed-off-by: Natasja <[email protected]>
use config in TestAlarmSchedulerCommandExecutor Signed-off-by: Natasja <[email protected]>
…larmSchedulerCommandExecutor
update unit tests Signed-off-by: Natasja <[email protected]>
update cucumber test TestAlarmScheduler with protocols and versions Signed-off-by: Natasja <[email protected]>
update cucumber test TestAlarmScheduler with protocols and versions Signed-off-by: Natasja <[email protected]>
…larmSchedulerCommandExecutor
update cucumber test TestAlarmScheduler with protocols and versions Signed-off-by: Natasja <[email protected]>
update cucumber test TestAlarmScheduler with protocols and versions Signed-off-by: Natasja <[email protected]>
revert wrong merge Signed-off-by: Natasja <[email protected]>
kroesctrl
requested changes
Oct 9, 2023
osgp/protocol-adapter-dlms/osgp-dlms/src/main/resources/dlmsprofiles/dlmsprofile-smr51.json
Outdated
Show resolved
Hide resolved
| "description": "execution time", | ||
| "datatype": "array", | ||
| "valuetype": "DYNAMIC", | ||
| "value": "EMPTY", |
There was a problem hiding this comment.
EMPTY staat niet in de specs
There was a problem hiding this comment.
EMPTY is verwijderd.
osgp/protocol-adapter-dlms/osgp-dlms/src/main/resources/dlmsprofiles/dlmsprofile-smr55.json
Outdated
Show resolved
Hide resolved
…larmSchedulerCommandExecutor
remove empty, add script DlmsDataType Signed-off-by: Natasja Nortier <[email protected]>
…larmSchedulerCommandExecutor
merge development Signed-off-by: Natasja Nortier <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
kroesctrl
approved these changes
Oct 24, 2023
natasja-n
deleted the
feature/SMHE-1740_configService_TestAlarmSchedulerCommandExecutor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use config service in TestAlarmSchedulerCommandExecutor
https://jenkins.fdp.osgp.cloud/view/SMHE-cucumber/job/gxf-smhe-cucumber-build/146/