FDP-94: Add monitoring and small fixes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jasper Kamerling <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]>
JelleHoffman
previously approved these changes
Nov 30, 2023
jasperkamerling
force-pushed
the
feature/FDP-94
branch
from
a0c7999 to
f6ffcc0
Compare
Signed-off-by: Jasper Kamerling <[email protected]>
jasperkamerling
force-pushed
the
feature/FDP-94
branch
from
f6ffcc0 to
ebb8f99
Compare
JelleHoffman
previously approved these changes
Dec 1, 2023
LucianoFavoroso
previously approved these changes
Dec 1, 2023
| .register(registry) | ||
| .record(duration) | ||
| } | ||
| } |
Signed-off-by: Jasper Kamerling <[email protected]>
jasperkamerling
dismissed stale reviews from LucianoFavoroso and JelleHoffman
via
17b5deb
jasperkamerling
force-pushed
the
feature/FDP-94
branch
from
ebb8f99 to
17b5deb
Compare
LucianoFavoroso
previously approved these changes
Dec 1, 2023
sanderv
requested changes
Dec 4, 2023
application/src/main/kotlin/org/gxf/soapbridge/monitoring/MonitoringService.kt
Outdated
Show resolved
Hide resolved
application/src/main/kotlin/org/gxf/soapbridge/monitoring/MonitoringService.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Is dit voldoende om ook bijv. fail-rates uit te halen? Of moeten we wat counters toeveoegen?
There was a problem hiding this comment.
Is het überhaupt nodig om fouten te timen? Kunnen we niet gerichter timeouts, technische exceptions etc. 'counten'?
kevinsmeets
reviewed
Dec 4, 2023
| createErrorResponse(response); | ||
| connectionCacheService.removeConnection(connectionId); | ||
| return; | ||
| } | ||
| } catch (final InterruptedException e) { | ||
| LOGGER.error("Error while waiting for response", e); | ||
| monitoringService.recordConnectionTime(startTime, request.getContextPath(), false); |
There was a problem hiding this comment.
Mogelijk is het nuttiger om errors te tellen. Eventueel naast het meten van de duratie.
Signed-off-by: Jasper Kamerling <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]>
…be found Signed-off-by: Jasper Kamerling <[email protected]>
sanderv
previously approved these changes
Dec 7, 2023
Signed-off-by: Jasper Kamerling <[email protected]>
jasperkamerling
force-pushed
the
feature/FDP-94
branch
from
78574e7 to
72682d2
Compare
Signed-off-by: Jasper Kamerling <[email protected]>
sanderv
previously approved these changes
Dec 7, 2023
|
|
||
| // After adding an entry it should be 1 | ||
| cacheMap["key"] = "value" | ||
| assertEquals(1.0, gauge.value()) |
There was a problem hiding this comment.
Actual first param, Expected as second param.
|
|
||
| // After reassigning the key it should stay at 1 | ||
| cacheMap["key"] = "new-value" | ||
| assertEquals(1.0, gauge.value()) |
There was a problem hiding this comment.
Actual first param, Expected as second param.
|
|
||
| // After adding a second key it should be 2 | ||
| cacheMap["new-key"] = "new-value" | ||
| assertEquals(2.0, gauge.value()) |
There was a problem hiding this comment.
Actual first param, Expected as second param.
|
|
||
| // Check if the meter exists and is 0 | ||
| assertNotNull(meterRegistry.find(CACHE_SIZE_METRIC).gauge()) | ||
| assertEquals(0.0, gauge.value()) |
There was a problem hiding this comment.
Actual first param, Expected as second param.
|
|
||
| } | ||
|
|
||
| } |
Signed-off-by: Jasper Kamerling <[email protected]>
LucianoFavoroso
approved these changes
Dec 7, 2023
|
Kudos, SonarCloud Quality Gate passed! |
sanderv
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.