FDP-94: Add option to not use organisation certificates #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jasper Kamerling <[email protected]>
sanderv
previously approved these changes
Nov 23, 2023
Signed-off-by: Jasper Kamerling <[email protected]>
sanderv
previously approved these changes
Nov 23, 2023
smvdheijden
reviewed
Nov 23, 2023
| /** | ||
| * TODO Can we search for certificates on both sides | ||
| * | ||
| * Property to not set common name based on the organisation on requests published to Kafka. |
There was a problem hiding this comment.
Suggested change
| * Property to not set common name based on the organisation on requests published to Kafka. | |
| * Property to set common name based on the organisation on requests published to Kafka. |
smvdheijden
reviewed
Nov 23, 2023
Comment on lines
26
to
27
| * This makes it so the other listening proxy doesn't search for certificates by [org.gxf.soapbridge.valueobjects.ProxyServerRequestMessage.commonName]. | ||
| * Instead, the other proxy will generate a new ssl context. |
There was a problem hiding this comment.
Suggested change
| * This makes it so the other listening proxy doesn't search for certificates by [org.gxf.soapbridge.valueobjects.ProxyServerRequestMessage.commonName]. | |
| * Instead, the other proxy will generate a new ssl context. | |
| * If set to false the other listening proxy doesn't search for certificates by [org.gxf.soapbridge.valueobjects.ProxyServerRequestMessage.commonName]. | |
| * Instead, the other proxy will generate a new ssl context. |
Signed-off-by: Jasper Kamerling <[email protected]>
smvdheijden
approved these changes
Nov 23, 2023
sanderv
approved these changes
Nov 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.