FDP-94: Add todo's

Signed-off-by: Jasper Kamerling <[email protected]>
OSGP · Nov 17, 2023 · a431a7b · a431a7b
1 parent a684d93
commit a431a7b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/...ion/src/main/java/org/gxf/soapbridge/application/factories/HttpsUrlConnectionFactory.java b/...ion/src/main/java/org/gxf/soapbridge/application/factories/HttpsUrlConnectionFactory.java
@@ -76,6 +76,7 @@ public HttpsURLConnection createConnection(
       connection.setSSLSocketFactory(sslContext.getSocketFactory());
       connection.setDoInput(true);
       connection.setDoOutput(true);
+      // TODO use constants for properties and method
       connection.setRequestMethod("POST");
       connection.setRequestProperty(
           "Accept-Encoding", "text/xml;charset=" + StandardCharsets.UTF_8.name());

diff --git a/application/src/main/java/org/gxf/soapbridge/soap/endpoints/SoapEndpoint.java b/application/src/main/java/org/gxf/soapbridge/soap/endpoints/SoapEndpoint.java
@@ -255,6 +255,7 @@ private void createSuccessFulResponse(final HttpServletResponse response, final
       throws IOException {
     LOGGER.debug("Start - creating successful response");
     response.setStatus(HttpServletResponse.SC_OK);
+    // TODO use constants for headers
     response.addHeader("SOAP-ACTION", "");
     response.addHeader("Keep-Alive", "timeout=5, max=100");
     response.addHeader("Accept", "text/xml");

diff --git a/...rc/main/kotlin/org/gxf/soapbridge/configuration/properties/SoapConfigurationProperties.kt b/...rc/main/kotlin/org/gxf/soapbridge/configuration/properties/SoapConfigurationProperties.kt
@@ -30,7 +30,7 @@ class SoapEndpointConfiguration(
     port: Int,
     protocol: String
 ) {
-
+    // TODO Use java.net.URI class
     val hostAndPort = "$host:$port"
     val uri = "$protocol://${hostAndPort}"
 }