FDP-2758: New SignableMessageWrapper that doesn't need subclassing #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sander Verbruggen <[email protected]>
levi-h
reviewed
Nov 4, 2024
| abstract class SignableMessageWrapper<T>(val message: T) { | ||
| class SignableMessageWrapper<T>( | ||
| val message: T, | ||
| private val messageGetter: Function<T, ByteBuffer>, |
There was a problem hiding this comment.
I would not use the java.util.function interfaces but the Kotlin syntax ((T) -> ByteBuffer in this case)
There was a problem hiding this comment.
It can then be invoked using .invoke(..) or just (...)
levi-h
reviewed
Nov 4, 2024
|
|
||
| /** @param signature The signature in ByteBuffer form to be set on the message */ | ||
| abstract fun setSignature(signature: ByteBuffer?) | ||
| fun setSignature(signature: ByteBuffer?) { | ||
| signatureSetter.accept(signature) |
There was a problem hiding this comment.
Here, message is not used (and it becomes the responsibility of the invoker to use the same message).
There was a problem hiding this comment.
(The signature of the setter parameter would then become (T, ByteBuffer?) -> Unit
levi-h
reviewed
Nov 4, 2024
| @@ -34,11 +33,12 @@ class MessageSignerTest { | |||
|
|
|||
| @Test | |||
| fun signsMessageWithoutSignature() { | |||
| val messageWrapper: SignableMessageWrapper<*> = this.messageWrapper() | |||
| val messageWrapper: SignableMessageWrapper<TestableMessage> = this.messageWrapper() | |||
There was a problem hiding this comment.
Old formatter left overs. Remove all the this's!
levi-h
reviewed
Nov 4, 2024
| override fun getSignature(): ByteBuffer? { | ||
| return this.signature | ||
| } | ||
| fun getSigBytes(): ByteBuffer? = this.signature |
Kotlin notation removed `this.` Signed-off-by: Sander Verbruggen <[email protected]>
Signed-off-by: Sander Verbruggen <[email protected]>
levi-h
approved these changes
Nov 4, 2024
Signed-off-by: Sander Verbruggen <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.