Skip to content

Commit

Permalink
Merge pull request #133 from OSGP/update-certs-path
Browse files Browse the repository at this point in the history
Updating path to certs directory;Failure on UpgradeProtocol when usin…
  • Loading branch information
dj-wasabi authored Dec 23, 2024
2 parents e431dde + fbcda4d commit 0089ebc
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

- uses: actions/setup-python@v4
with:
python-version: 3.7
python-version: 3.11

- name: Set up chart-testing
uses: helm/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion charts/gxf/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: gxf
description: Generic GXF Helm chart
version: '1.8.3'
version: '1.8.4'
icon: https://artwork.lfenergy.org/projects/grid-exchange-fabric/abbrev/color/grid-exchange-fabric-abbrev-color.png
maintainers:
- name: OSGP
Expand Down
8 changes: 4 additions & 4 deletions charts/gxf/config/tomcat/server.xml
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ SPDX-License-Identifier: Apache-2.0
secretRequired="false" />
{{- end }}
{{- if and .Values.httpsConnector.enabled (not .Values.httpdSidecar.enabled) }}
<Connector port="8443" protocol="org.apache.coyote.http11.Http11AprProtocol"
<Connector port="8443" protocol="org.apache.coyote.http11.Http11NioProtocol"
maxThreads="{{ $maxThreads }}" SSLEnabled="true" >
<UpgradeProtocol className="org.apache.coyote.http2.Http2Protocol" />
<SSLHostConfig>
<Certificate certificateKeyFile="/etc/ssl/certs/server.key"
<Certificate certificateKeyFile="/certs/server.key"
certificateKeyPassword="${CERTIFICATE_KEY_PASSWORD}"
certificateFile="/etc/ssl/certs/server.crt"
certificateFile="/certs/server.crt"
{{- if .Values.httpsConnector.clientAuthEnabled }}
caCertificateFile="/etc/ssl/certs/root.crt"
caCertificateFile="/certs/root.crt"
SSLVerifyClient={{ .Values.httpsConnector.SSLVerifyClient | default "optional" | quote }}
{{- end }}
type="RSA" />
Expand Down
5 changes: 5 additions & 0 deletions charts/gxf/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ spec:
name: http
protocol: TCP
{{- end }}
{{- if .Values.httpsConnector.enabled }}
- containerPort: 8443
name: https
protocol: TCP
{{- end }}
{{- range .Values.extraPorts }}
- containerPort: {{ .port }}
name: {{ .name }}
Expand Down
5 changes: 5 additions & 0 deletions charts/gxf/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ spec:
port: 443
targetPort: https
{{- end }}
{{- if .Values.httpsConnector.enabled }}
- name: https
port: 8443
targetPort: https
{{- end }}
{{- range .Values.extraServicePorts }}
- name: {{ $.Release.Name }}-{{ .name }}
port: {{ .port }}
Expand Down

0 comments on commit 0089ebc

Please sign in to comment.