Feature/IOT-1209-MoveGateway #256
Conversation
|
internalOrganizationId, bliver opdateret med kald til modifyGateway i chirpstack-gateway.service. |
MadsApollo
changed the title
| @Body() dto: UpdateGatewayOrganizationDto | ||
| ): Promise<DbGateway> { | ||
| checkIfUserHasAccessToOrganization(req, dto.organizationId, OrganizationAccessScope.GatewayWrite); | ||
| const gateway = await this.chirpstackGatewayService.updateOrganization(id, dto, req); |
There was a problem hiding this comment.
jeg skal have et fail log.
…e, with default permissions if none specified.
| where: { id: gatewayId }, | ||
| relations: [nameof<DbGateway>("organization")], | ||
| }); | ||
| checkIfUserHasAccessToOrganization(req, dto.organizationId, OrganizationAccessScope.GatewayWrite); |
There was a problem hiding this comment.
Du har allerede lavet access checket i controlleren, så ingen grund til at gøre det igen
There was a problem hiding this comment.
var lidt i tvivl om hvordan deres decorators helt præcis er stykket sammen.
There was a problem hiding this comment.
ah kan se at kaldet faktisk også er i controlleren , gotcha
| @@ -7,6 +7,9 @@ export class UpdateGatewayContentsDto extends OmitType(GatewayContentsDto, ["gat | |||
| @ApiHideProperty() | |||
| gatewayId: string; | |||
|
|
|||
| @ApiHideProperty() | |||
| organizationId?: string; | |||
There was a problem hiding this comment.
Bruges den her nogen steder?
There was a problem hiding this comment.
Nej, havde en ide om at modificere update dto'en, til at både opdatere chirpstack og db'en. jeg fjerner den.
…y of update contents dto.
No description provided.