Skip to content

Commit

Permalink
#36 Added TODO comments for later
Browse files Browse the repository at this point in the history
  • Loading branch information
j3nsch committed Oct 7, 2022
1 parent 70b1f77 commit f9338a4
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/Importer.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@
* With every new context, every new use case this code will get more complicated. It would be better if the
* different context would be implemented in separate classes that extend a base class providing common
* functionality.
*
* TODO all those private functions make testing difficult and prevent this class from being extended to customize
* the import process - revisit the design of this class
*/
class Importer
{
Expand Down Expand Up @@ -780,6 +783,8 @@ private function handleSeries($node, $doc)
*
* @param DOMNode $node
* @param Document $doc
*
* TODO add unit test - a bug that prevented the NotFoundException was not automatically detected
*/
private function handleEnrichments($node, $doc)
{
Expand Down

0 comments on commit f9338a4

Please sign in to comment.