Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umsetzung von Collection-NestedSet-Struktur mit DoctrineExtensions #227

Draft
wants to merge 27 commits into
base: doctrine
Choose a base branch
from
Draft

Umsetzung von Collection-NestedSet-Struktur mit DoctrineExtensions #227

wants to merge 27 commits into from

Conversation

extracts
Copy link
Contributor

@extracts extracts commented Dec 10, 2021 •
edited
Loading

PR für #220.

Im Unterschied zu #131 wird in diesem PR die Doctrine "Tree" extension genutzt, um mittels der Model2\Collection Klasse ein NestedSet-Verhalten zu implementieren.

Zumindest der Test CollectionTest->testNestedSet sollte mit den Änderungen in diesem PR erfolgreich durchlaufen.

Die meisten anderen Tests in CollectionTest müssten allerdings noch überarbeitet werden und Properties/Funktionen in den Klassen Model2\Collection & Model2\CollectionRole ergänzt werden.

@extracts
#220 Converts the Collection & CollectionRole model classes to use Do…
f9144ec 
…ctrine ORM (using the Doctrine "Tree" extension to implement nested-set behavior)
@extracts extracts requested a review from j3nsch December 10, 2021 15:50
@extracts extracts linked an issue Dec 10, 2021 that may be closed by this pull request
Umsetzung von Collection-NestedSet-Struktur mit DoctrineExtensions #220
Open
@j3nsch j3nsch marked this pull request as draft January 5, 2022 08:11
@j3nsch
Copy link
Member

j3nsch commented Jan 5, 2022

Ich versuche die Tests mal mit PHP 7.2 laufen zu lassen, um einschätzen zu können, wieviele Probleme es gibt durch die alten Zend-Abhängigkeiten.

@j3nsch
Copy link
Member

j3nsch commented Jan 5, 2022

Ich habe die Tests auf tests/Opus/CollectionTest.php reduziert. Die Fehler scheinen im Augenblick nichts mit Zend an sich zu tun zu haben, obwohl beim Durchlauf mit allen Tests sah es schon so aus als ob sich PHP 7.2 negativ auf Zend_Db auswirken würde. Wenn wir die Tests hier auf den neuen Code begrenzen, also nur eine Testklasse oder vielleicht eine Gruppe von Tests in phpunit.xml definieren, dann könnten wir hier mit einer Proof-of-Concept Implementation vorwärt gehen.

extracts added 22 commits February 9, 2022 19:55
@extracts
Merge branch 'doctrine' of github.com:OPUS4/framework into issue220
c960549
@extracts
#220 For the Vagrantfile, use PHP 7.2 as required by gedmo/doctrine-e…
b307f7f 
…xtensions 3.0
@extracts
#220: Updated code & package dependencies as required by gedmo/doctri…
e5f3f2e 
…ne-extensions 3.0
@extracts
Merge branch 'doctrine' of github.com:OPUS4/framework into issue220
0218da4
@extracts
#220 Where appropriate, use an InvalidArgumentException (instead of j…
d08cdd3 
…ust Exception)
@extracts
#220 Adds tree functions to set the first/last child of a Collection …
e453fa3 
…node
@extracts
#220 Adds stub functions to get & set the collection's theme
d32a340
@extracts
#220 Adds support for more CollectionRole database properties
95183db
@extracts
#220 Adds function CollectionRole->addRootCollection() (WIP)
bc9df6d
@extracts
#220 Adopts code to Doctrine's way of getting an existing Collection …
8c603ab 
…instance by ID
@extracts
#220 CollectionTest now uses Opus\Model2\CollectionRole and adopts co…
8cb97aa 
…de to PHPUnit v6
@extracts
#220 Installs Xdebug to enable debugging with an IDE such as PhpStorm
cc5af37
@extracts
#220 CollectionTest->setUp() now directly persists the root collectio…
a6d7292 
…n; this prevents some tests from throwing Doctrine exceptions due to the CollectionRole->rootCollection relationship currently not being set to cascade persist
@extracts
#220 Similar to e453fa3, adds more tree functions that make use of th…
9a4c35a 
…e Doctrine Tree extension
@extracts
#220 The getChildren() function now always returns an array, and it u…
f919371 
…ses the children() function of the Doctrine Tree extension to return the direct children of a Collection instance
@extracts
#220 Just adds/changes some TODOs
c9a83d9
@extracts
#220 Removes code that isn't needed anymore with the Doctrine/ORM imp…
f0455d5 
…lementation
@extracts
#220 Set Collection parent & children properties directly
5d59e5b
@extracts
#220 Set Doctrine/ORM cascade rules for Collection and CollectionRole…
85ec16a 
… relationships
@extracts
#220 Removes again the Doctrine/ORM cascade rules for the Collection-…
165cadb 
…>children relationship
@extracts
#220 Collection->getChildren() now only returns the direct children o…
0240557 
…f a given object
@extracts
#220 Added a TODO about the apparent need to set Collection->roleId e…
55bb779 
…xplicitly
@extracts
#220 CollectionRole->addRootCollection() now always ensures that the …
ab7ccb9 
…role relationship is set for the root collection
@extracts
#220 Adds CollectionTest tests that test if deleting (or storing) the…
96291e6 
… root collection also deletes (or stores) its entire children tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j3nsch j3nsch Awaiting requested review from j3nsch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Umsetzung von Collection-NestedSet-Struktur mit DoctrineExtensions
2 participants
@extracts @j3nsch