#153 Coding style fixes

OPUS4 · Jan 17, 2023 · d0658a3 · d0658a3
1 parent c6ed037
commit d0658a3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/modules/admin/forms/Document/MultiIdentifierSubForm.php b/modules/admin/forms/Document/MultiIdentifierSubForm.php
@@ -344,7 +344,7 @@ public function processPost($data, $context)
 
                     // wenn nur noch ein Eingabefeld für Identifier des Typs übrig bleibt: Generieren-Button anzeigen
                     if (count($this->getSubForms()) === 1) {
-                        $subforms = $this->getSubForms();
+                        $subforms    = $this->getSubForms();
                         $firstIdForm = reset($subforms); // TODO ERROR ?
                         $this->addGenerateButton($firstIdForm, false);
                         // TODO ohne den nachfolgenden Aufruf wird der Button nicht neben,

diff --git a/modules/oai/models/Request.php b/modules/oai/models/Request.php
@@ -31,9 +31,10 @@
  */
 
 use Opus\Common\Log;
+use Opus\Common\Security\Realm;
 
 /**
- * TODO documentation is not existent - especially the fact that 'validate' functions are called dynamically
+ * TODO BUG documentation is not existent - especially the fact that 'validate' functions are called dynamically
  */
 class Oai_Model_Request
 {
@@ -45,11 +46,11 @@ class Oai_Model_Request
     /** @var string */
     private $errorMessage;
 
-    /* @var string
-    private $pathToMetadataPrefixFiles; */
+    /* @var string */
+    private $pathToMetadataPrefixFiles;
 
-    /** @var string
-    private $resumptionPath; */
+    /** @var string */
+    private $resumptionPath;
 
     /** @var string[] */
     private $validArguments = [
@@ -136,8 +137,7 @@ public function checkDate($datestr)
      * TODO handling case insensitivity of metadataPrefix is spread through the code (here and other places)
      * TODO function handles access control in addition to checking if format is supported (mixed responsibilities)
      */
-    /* TODO LAMINAS unused function
-    private function validateMetadataPrefix($oaiMetadataPrefix)
+    public function validateMetadataPrefix($oaiMetadataPrefix)
     {
         // we assuming that a metadata prefix file ends with xslt
         $possibleFiles = glob($this->pathToMetadataPrefixFiles . DIRECTORY_SEPARATOR . '*.xslt');
@@ -165,7 +165,6 @@ private function validateMetadataPrefix($oaiMetadataPrefix)
 
         return $result;
     }
-    */
 
     /**
      * Checks if given 'from' date is valid.
@@ -238,9 +237,8 @@ public function validateFromUntilRange($from, $until)
      *
      * @param  string $oaiResumptionToken The resumption token to validate.
      * @return bool
-     *
-     * TODO LAMINAS unused function
-    private function validateResumptionToken($oaiResumptionToken)
+     */
+    public function validateResumptionToken($oaiResumptionToken)
     {
         $tokenWorker = new Oai_Model_Resumptiontokens();
 
@@ -264,7 +262,6 @@ private function validateResumptionToken($oaiResumptionToken)
 
         return $result;
     }
-     */
 
     /**
      * Returns current error code.