(stm32) drivers: stm32_tamp: add support for stm32mp25x platforms + backup register config from DT #7129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Nov 18, 2024
etienne-lms
reviewed
Nov 18, 2024
|
Patchset reorganized and most of the comments applied. Some answers to you suggestions remaining. |
etienne-lms
reviewed
Nov 19, 2024
core/drivers/stm32_tamp.c
Outdated
| bkpregs_count = fdt32_to_cpu(cuint[0]); | ||
|
|
||
| pdata->bkpregs_conf->zone2_end = bkpregs_count + | ||
| fdt32_to_cpu(cuint[1]); |
There was a problem hiding this comment.
Check DT property consistency?
assert(pdata->bkpregs_conf->zone2_end + fdt32_to_cpu(cuint[2]) ==
stm32_tamp_dev->hwconf1 & _TAMP_HWCFGR1_BKPREG);More than checking the consistency, it would highlight why we expect 3 cells but read only the 2 first.
There was a problem hiding this comment.
Cannot do this at this stage of the probe sequence. I'll keep as is.
|
Comments addressed. Added a temporary |
etienne-lms
reviewed
Nov 19, 2024
core/include/drivers/stm32_tamp.h
Outdated
| */ | ||
| struct stm32_bkpregs_conf { | ||
| uint32_t nb_zone1_regs; | ||
| uint32_t nb_zone2_regs; | ||
| uint32_t *rif_offsets; |
There was a problem hiding this comment.
Can discard changes in stm32_tamp.h.
etienne-lms
reviewed
Nov 19, 2024
etienne-lms
reviewed
Nov 19, 2024
etienne-lms
reviewed
Nov 21, 2024
|
Comments addressed |
etienne-lms
reviewed
Nov 25, 2024
core/drivers/stm32_tamp.c
Outdated
| * | ||
| * (BHK => First 8 registers) | ||
| */ | ||
| pdata->bkpregs_conf.rif_offsets = calloc(4, sizeof(uint32_t)); |
There was a problem hiding this comment.
s/4/TAMP_RIF_OFFSET_CNT/
There was a problem hiding this comment.
Also adding a define for the number of zones.
etienne-lms
reviewed
Nov 25, 2024
|
Comments addressed |
|
|
Add st,backup-zones property in TAMP node in stm32mp131.dtsi. It defines the topology of the backup registers zones. The number of zones on stm32mp13x platforms is 3. Signed-off-by: Gatien Chevallier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Add st,backup-zones property in TAMP node in stm32mp151.dtsi. It defines the topology of the backup registers zones. The number of zones on stm32mp13x platforms is 3. Signed-off-by: Gatien Chevallier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Add support for the RIF configuration of the TAMP peripheral. It covers the TAMP resources such as monotonic counters but also backup registers regions and sub-regions. Create a stm32_tamp_platdata structure to hold platform data. Add temporary stm32_bkpregs_conf_new structure that will be used by the new implementation and renamed to stm32_bkpregs_conf when the old one disappear. Signed-off-by: Gatien Chevallier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Add TAMP peripheral node in stm32mp251.dtsi. The TAMP peripheral manages monotonic counters, tamper events and backup registers. Signed-off-by: Gatien Chevallier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Add a TAMP RIF configuration for stm32mp257f-ev1 board to configure backup registers and TAMP resources. Signed-off-by: Gatien Chevallier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
…obing Update the driver to be able to configure the backup registers when the driver is probing and remove call to stm32_tamp_set_secure_bkpregs() in plat-stm32mp1 main.c. Remove old implementation of stm32_bkpregs_conf structure and rename stm32_bkpregs_conf_new to stm32_bkpregs_conf. Signed-off-by: Gatien Chevallier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Default enable TAMP peripheral support for stm32mp2x platforms. Signed-off-by: Gatien Chevallier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
|
Tags applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P-R implements the backup registers configuration from the device tree and the stm32mp25x support.
It has a dependency on #7125 and should be merged afterwards.
There is a default st,backup-zones property at SoC level as it is mandatory to configure the backup registers secure level on our platforms. It can be superseeded at platform level.