[review] drivers: stm32_gpio: check secure state of pinctrl states

Check each pins can be accessed when applying a pinctrl state. Return TEE_ERROR_SECURITY instead of TEE_ERROR_GENERIC when failing to apply a pinctrl state due to the pin configuration access rights. Signed-off-by: Etienne Carriere <[email protected]>
OP-TEE · Nov 12, 2024 · c3886b1 · c3886b1
1 parent 95e5abf
commit c3886b1
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/core/drivers/stm32_gpio.c b/core/drivers/stm32_gpio.c
@@ -1291,6 +1291,13 @@ static TEE_Result stm32_pinctrl_conf_apply(struct pinconf *conf)
 	for (n = 0; n < pin_count; n++) {
 		struct stm32_gpio_bank *bank = stm32_gpio_get_bank(p[n].bank);
 
+		if (!pin_is_accessible(bank, p[n].pin)) {
+			EMSG("Apply pinctrl for pin %c%u that cannot be accessed",
+			     p[n].bank + 'A', p[n].pin);
+			error = true;
+			continue;
+		}
+
 		if (p[n].cfg.nsec == !pin_is_secure(bank, p[n].pin))
 			continue;
 
@@ -1309,7 +1316,7 @@ static TEE_Result stm32_pinctrl_conf_apply(struct pinconf *conf)
 	}
 
 	if (error)
-		return TEE_ERROR_GENERIC;
+		return TEE_ERROR_SECURITY;
 
 	for (n = 0; n < pin_count; n++)
 		set_gpio_cfg(p[n].bank, p[n].pin, &p[n].cfg);