form number xpath and notices without namespaces #81
Conversation
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 59 59
Lines 2362 2362
=======================================
Hits 2340 2340
Misses 22 22
Continue to review full report at Codecov.
|
| @@ -117,7 +117,7 @@ def xpath_legal_basis_directive_third(self): | |||
|
|
|||
| @property | |||
| def xpath_form_number(self): | |||
| return "manifestation_ns:FORM_SECTION/*[1]" | |||
| return ".//*[@FORM]" | |||
There was a problem hiding this comment.
that is way way better and more robust
| @@ -263,7 +263,7 @@ def _get_normalised_namespaces(self): | |||
| namespaces = dict([node for _, node in ET.iterparse(source=StringIO(self.xml_manifestation.object_data), | |||
| events=['start-ns'])]) | |||
|
|
|||
| namespaces["manifestation_ns"] = namespaces.pop("") | |||
| namespaces["manifestation_ns"] = namespaces.pop("") if "" in namespaces.keys() else "" | |||
There was a problem hiding this comment.
Why do we remove the default NS? If that is for Semantic engineers, then we no longer need it. the XPath works with default namespace now.
There was a problem hiding this comment.
I had a notice that didn't have namespace from the test data in the F03 package. So it is a safety net in case it will come without namespace
No description provided.