Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ted 180 #57

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Feature/ted 180 #57

merged 6 commits into from
Apr 12, 2022

Conversation

kaleanych
Copy link
Contributor

No description provided.

@kaleanych kaleanych requested a review from costezki April 12, 2022 21:03
Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Makefile Show resolved Hide resolved
ted_sws/core/__init__.py Show resolved Hide resolved
ted_sws/core/adapters/logger.py Show resolved Hide resolved
ted_sws/core/adapters/logger.py Show resolved Hide resolved
ted_sws/core/domain/message_bus.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #57 (702b9f5) into main (7fd0c1b) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   98.76%   98.83%   +0.07%     
==========================================
  Files          45       49       +4     
  Lines        1699     1808     +109     
==========================================
+ Hits         1678     1787     +109     
  Misses         21       21              
Impacted Files Coverage Δ
ted_sws/core/adapters/vault_secrets_store.py 97.14% <ø> (ø)
ted_sws/core/model/notice.py 98.74% <ø> (ø)
ted_sws/__init__.py 93.10% <100.00%> (+2.62%) ⬆️
ted_sws/core/__init__.py 100.00% <100.00%> (ø)
ted_sws/core/adapters/logger.py 100.00% <100.00%> (ø)
ted_sws/core/domain/message_bus.py 100.00% <100.00%> (ø)
ted_sws/core/domain/message_handlers.py 100.00% <100.00%> (ø)
ted_sws/core/model/message.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d55e46...702b9f5. Read the comment docs.

@kaleanych kaleanych merged commit 804f532 into main Apr 12, 2022
@costezki costezki deleted the feature/TED-180 branch April 22, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants