Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ted 915 #395

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Feature/ted 915 #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b35b06a
Updated validation summary report
Dec 6, 2022
799efcf
Updates related to triple_store_loader issue investigation
Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ted_sws/data_manager/adapters/triple_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
from ted_sws import config
from ted_sws.data_manager.adapters.sparql_endpoint import TripleStoreEndpointABC, SPARQLTripleStoreEndpoint


FUSEKI_REPOSITORY_ALREADY_EXIST_ERROR_MSG = 'A repository with this name already exists.'


class TripleStoreABC:
@abc.abstractmethod
def create_repository(self, repository_name: str):
Expand Down
2 changes: 1 addition & 1 deletion ted_sws/mapping_suite_processor/services/load_mapping_suite_output_into_triple_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pathlib

from ted_sws import config
from ted_sws.data_manager.adapters.triple_store import AllegroGraphTripleStore, FusekiAdapter, TripleStoreABC
from ted_sws.data_manager.adapters.triple_store import FusekiAdapter, TripleStoreABC


def repository_exists(triple_store: TripleStoreABC, repository_name) -> bool:
Expand Down
4 changes: 2 additions & 2 deletions ted_sws/notice_validator/entrypoints/cli/cmd_validation_summary_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def run_cmd(self):
return self.run_cmd_result()


def run(mapping_suite_id=None, notice_id=None, notice_aggregate=False, opt_mappings_folder=DEFAULT_MAPPINGS_PATH):
def run(mapping_suite_id=None, notice_id=None, notice_aggregate=True, opt_mappings_folder=DEFAULT_MAPPINGS_PATH):
cmd = CmdRunner(
mapping_suite_id=mapping_suite_id,
notice_id=notice_id,
Expand All @@ -162,7 +162,7 @@ def run(mapping_suite_id=None, notice_id=None, notice_aggregate=False, opt_mappi
@click.command()
@click.argument('mapping-suite-id', nargs=1, required=True)
@click.option('--notice-id', required=False, multiple=True, default=None)
@click.option('--notice-aggregate', required=False, default=False, type=click.BOOL)
@click.option('--notice-aggregate', required=False, default=True, type=click.BOOL)
@click.option('-m', '--opt-mappings-folder', default=DEFAULT_MAPPINGS_PATH)
def main(mapping_suite_id, notice_id, notice_aggregate, opt_mappings_folder):
"""
Expand Down
4 changes: 3 additions & 1 deletion ted_sws/notice_validator/resources/templates/validation_summary_report.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@
{% else %}
<ul>
{% for nid in notice_ids %}
<li><a href="{{ nid }}/test_suite_report/validation_summary_report.html" target="_blank">{{ nid }}</a></li>
<li>
<a href="{{ nid }}/test_suite_report" target="_blank">{{ nid }}</a>
</li>
{% endfor %}
</ul>
{% endif %}
Expand Down