Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added form and notice type in metadata normaliser #37

Merged
merged 3 commits into from
Mar 25, 2022
Merged

added form and notice type in metadata normaliser #37

merged 3 commits into from
Mar 25, 2022

Conversation

Dragos0000
Copy link
Collaborator

No description provided.

costezki
costezki approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Nice attempt to generalise filtering over resource files with pandas queries.

ted_sws/metadata_normaliser/resources/mapping_files_registry.py Show resolved Hide resolved
ted_sws/metadata_normaliser/resources/mapping_files_registry.py Show resolved Hide resolved
ted_sws/metadata_normaliser/services/metadata_normalizer.py

JOIN_SEP = " :: "
MERGING_COLUMN = "eforms_subtype"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but looks solitary. Do we need perhaps, the other columns as well?

ted_sws/metadata_normaliser/services/metadata_normalizer.py Outdated Show resolved Hide resolved
tests/unit/metadata_normaliser/test_mapping_files_registry.py Outdated Show resolved Hide resolved
tests/unit/metadata_normaliser/test_metadata_normaliser.py Show resolved Hide resolved
@Dragos0000 Dragos0000 merged commit 8d16332 into main Mar 25, 2022
@Dragos0000 Dragos0000 deleted the feature/TED-163 branch March 25, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costezki costezki costezki approved these changes

@CaptainOfHacks CaptainOfHacks Awaiting requested review from CaptainOfHacks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dragos0000 @costezki