Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tda 911 #346

Merged
merged 8 commits into from
Nov 8, 2022
Merged

Feature/tda 911 #346

merged 8 commits into from
Nov 8, 2022

Conversation

duprijil
Copy link
Collaborator

@duprijil duprijil commented Nov 7, 2022

No description provided.

@duprijil duprijil added the enhancement New feature or request label Nov 7, 2022
@duprijil duprijil self-assigned this Nov 7, 2022
@duprijil
Copy link
Collaborator Author

duprijil commented Nov 7, 2022

Remain for future to replace db in tests with fake one.

ted_sws/__init__.py Outdated Show resolved Hide resolved
ted_sws/__init__.py Outdated Show resolved Hide resolved
ted_sws/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@CaptainOfHacks CaptainOfHacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, revise comments before merge.

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 99.11% // Head: 99.03% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (551ff05) compared to base (e73ea9b).
Patch coverage: 88.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   99.11%   99.03%   -0.08%     
==========================================
  Files         119      121       +2     
  Lines        6000     6034      +34     
==========================================
+ Hits         5947     5976      +29     
- Misses         53       58       +5     
Impacted Files Coverage Δ
...processor/services/mapping_suite_digest_service.py 100.00% <ø> (ø)
...ter_data_registry/services/entity_deduplication.py 94.11% <50.00%> (-4.82%) ⬇️
ted_sws/core/model/metadata.py 100.00% <100.00%> (ø)
ted_sws/core/model/transform.py 100.00% <100.00%> (ø)
ted_sws/data_manager/adapters/triple_store.py 97.08% <100.00%> (+0.02%) ⬆️
ted_sws/data_manager/services/__init__.py 100.00% <100.00%> (ø)
...vices/create_batch_collection_materialised_view.py 100.00% <100.00%> (ø)
...ices/create_notice_collection_materialised_view.py 100.00% <100.00%> (ø)
...notice_publisher/adapters/sftp_notice_publisher.py 100.00% <100.00%> (ø)
..._sws/notice_publisher/services/notice_publisher.py 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@duprijil duprijil merged commit ef42542 into main Nov 8, 2022
@duprijil duprijil deleted the feature/TDA-911 branch November 8, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants