New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ted 817 #295

Merged

CaptainOfHacks merged 3 commits into main from feature/TED-817

Oct 10, 2022

Collaborator

CaptainOfHacks commented Oct 10, 2022

No description provided.

CaptainOfHacks added 2 commits

October 10, 2022 14:11

WIP

58fbeea


          fix validate_and_update_daily_supra_notice

877b389

request_api was None as default

CaptainOfHacks requested review from kaleanych, costezki and Dragos0000

October 10, 2022 11:22

swarmia bot commented Oct 10, 2022

✅ Linked to Bug TED-817 · Fix notice_daily_validation_workflow


          Update notice_validation_workflow.py

b099f17

codecov-commenter commented Oct 10, 2022 •

edited

Loading

Codecov Report

Base: 99.03% // Head: 99.01% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (877b389) compared to base (32a2ffa).
Patch coverage: 66.66% of modified lines in pull request are covered.

❗ Current head 877b389 differs from pull request most recent head b099f17. Consider uploading reports for the commit b099f17 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   99.03%   99.01%   -0.02%     
==========================================
  Files         106      106              
  Lines        5483     5485       +2     
==========================================
+ Hits         5430     5431       +1     
- Misses         53       54       +1

Impacted Files	Coverage Δ
..._notice_manager/services/supra_notice_validator.py	`97.91% <66.66%> (-2.09%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kaleanych approved these changes

View reviewed changes

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

CaptainOfHacks merged commit 4904633 into main

CaptainOfHacks deleted the feature/TED-817 branch

October 10, 2022 11:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet