Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication Notice URI #280

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Publication Notice URI #280

merged 3 commits into from
Sep 30, 2022

Conversation

kaleanych
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Dragos0000 Dragos0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comment

@@ -38,10 +38,6 @@ def normalize_value(cls, value: str) -> str:
def denormalize_value(cls, value: str) -> str:
return value.replace(NORM_SEP, DENORM_SEP)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename NORM_SEP and DENORM_SEP into something more meaningful and readable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename them how you wish. Names stand for DENORMALIZATION_SEPARATOR and NORMALIZATION_SEPARATOR

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 98.75% // Head: 98.64% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (63b1786) compared to base (fb4447a).
Patch coverage: 90.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   98.75%   98.64%   -0.12%     
==========================================
  Files         114      103      -11     
  Lines        5319     5239      -80     
==========================================
- Hits         5253     5168      -85     
- Misses         66       71       +5     
Impacted Files Coverage Δ
...ed_sws/data_sampler/services/notice_xml_indexer.py 100.00% <ø> (ø)
...notice_validator/services/xpath_coverage_runner.py 100.00% <ø> (ø)
...services/check_availability_of_notice_in_cellar.py 61.11% <30.00%> (-38.89%) ⬇️
ted_sws/data_manager/adapters/notice_repository.py 96.01% <33.33%> (-0.95%) ⬇️
...ed_sws/notice_packager/services/notice_packager.py 97.27% <40.00%> (-2.73%) ⬇️
...ices/conceptual_mapping_generate_sparql_queries.py 95.09% <92.30%> (-4.91%) ⬇️
ted_sws/core/model/manifestation.py 100.00% <100.00%> (ø)
ted_sws/core/model/transform.py 100.00% <100.00%> (ø)
.../data_manager/adapters/mapping_suite_repository.py 100.00% <100.00%> (ø)
ted_sws/event_manager/services/log.py 100.00% <100.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaleanych kaleanych merged commit 3791f09 into main Sep 30, 2022
@kaleanych kaleanych deleted the feature/TED-559 branch September 30, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants