-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publication Notice URI #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address comment
@@ -38,10 +38,6 @@ def normalize_value(cls, value: str) -> str: | |||
def denormalize_value(cls, value: str) -> str: | |||
return value.replace(NORM_SEP, DENORM_SEP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rename NORM_SEP and DENORM_SEP into something more meaningful and readable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename them how you wish. Names stand for DENORMALIZATION_SEPARATOR and NORMALIZATION_SEPARATOR
SonarCloud Quality Gate failed. |
Codecov ReportBase: 98.75% // Head: 98.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 98.75% 98.64% -0.12%
==========================================
Files 114 103 -11
Lines 5319 5239 -80
==========================================
- Hits 5253 5168 -85
- Misses 66 71 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
No description provided.