Feature/ted 617 #220
Merged
Feature/ted 617 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costezki
reviewed
Aug 22, 2022
| from ted_sws import config | ||
|
|
||
|
|
||
| def update_digest_api_address_for_mapping_suite(mapping_suite: MappingSuite, |
There was a problem hiding this comment.
I have seen this already in the other PR?!
Why is it here?
Dragos0000
reviewed
Aug 26, 2022
| @@ -209,16 +209,17 @@ def _validate_transformed_rdf_manifestation(**context_args): | |||
| mongodb_client = MongoClient(config.MONGO_DB_AUTH_URL) | |||
| notice_repository = NoticeRepository(mongodb_client=mongodb_client) | |||
| mapping_suite_repository = MappingSuiteRepositoryMongoDB(mongodb_client=mongodb_client) | |||
| validate_xpath_coverage_notice_by_id(notice_id=notice_id, mapping_suite_identifier=mapping_suite_id, | |||
There was a problem hiding this comment.
Why is this in old_worker_single_notice_process.....py file? do we have a new one?
There was a problem hiding this comment.
Should this be in the other file ?
There was a problem hiding this comment.
it's the refactoring Stefan is doing.
I think it will be aligned when he finishes he's game.
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.