Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in fix from pubsub 0.42.x to reduce log output #25

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

jcox-dev
Copy link
Contributor

@jcox-dev jcox-dev commented Jul 3, 2019

Motivation and Context

Container logs from this service were spiking at over 1,000 lines/sec in GCP / Stackdriver. This was apparently due to a bug in the client package (where the subscriber panics on network changes), which should now be fixed in google-cloud-pubsub>=0.42.0.

Fix: googleapis/google-cloud-python#8193

What has changed

  • Ran pipenv update to update Python packages in lock file

@jcox-dev jcox-dev changed the title Pull in fix from google-cloud-pubsub 0.42.x to prevent log spam Pull in fix from google-cloud-pubsub 0.42.x to prevent log Jul 3, 2019
@jcox-dev jcox-dev changed the title Pull in fix from google-cloud-pubsub 0.42.x to prevent log Pull in fix from google-cloud-pubsub 0.42.x to reduce log output Jul 3, 2019
@jcox-dev jcox-dev changed the title Pull in fix from google-cloud-pubsub 0.42.x to reduce log output Pull in fix from google-cloud-pubsub 0.42.x reduce log output Jul 3, 2019
@jcox-dev jcox-dev changed the title Pull in fix from google-cloud-pubsub 0.42.x reduce log output Pull in fix from pubsub 0.42.x to reduce log output Jul 3, 2019
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files           4        4           
  Lines         122      122           
=======================================
  Hits          118      118           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a9e16...bc6381f. Read the comment docs.

@jcox-dev jcox-dev merged commit e658f06 into master Jul 3, 2019
@jcox-dev jcox-dev deleted the update-pubsub-client branch July 3, 2019 08:26
@AdamHawtin AdamHawtin added this to the v1.0.0 milestone Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants