2.1 negative net flows #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of everything I delete
Another set of refactoring coming once Jorge updates outputs in main
Removes unneccessary CSV files.
We are still missing Syria as a country in the first iteration, but include SYria in the final iteration, so this is slightly inflating figures.
…locks Requires debugging as 'add_latest_year_for_missing_gdp_data is currently misaligned.
jm-rivera
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Thanks @Mattie-P!
See my comments, particularly on the missing gdp data, and make the relevant changes.
For the rest, for readability, it would be good to organise the script in a more 'logical' way, putting functions in more or less the order that they are used later.
Otherwise it is a well documented, well written, well structured script. Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to add data behind number of countries with negative net flows. Only consider final commit. There is a lot of trial and error in early commits.