Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIS 12: Invoice Loan Seller Reference App Logs #1832

Open
wants to merge 67 commits into
base: main
Choose a base branch
from

Conversation

Avijeet-Blocsol
Copy link
Contributor

Hello ONDC Team,

We are sharing our logs for verification for our Invoice Credit Seller Reference Application. Looking forward to your response.

@anuj-ondc
Copy link

@Avijeet-Blocsol, Please fix below issues:

common issues:

  • KFS_LINK is missing.

Flow 1:

search:

  • Remove provider reference.

on_search 2:

  • Item id is not matching with previous call.

init_2:

  • In payments, params values are empty strings

on_confirm:

  • Invalid fulfillment state.

on_update 1:

  • GRO_DESIGNATION & GRO_ADDRESS tags are missing
  • Remove LOAN_CANCELLATION document.

on_update 2:

  • Invalid fulfillment state.

Flow 2 PRE_PART_PAYMENT:

update:

  • Remove fulfillments

on_update 3:

  • In context, message_id is not matching.

on_update 4:

  • In payments, 2 object found with PRE_PART_PAYMENT.
  • In payments, some payment obejcts are missing.

Flow 3 MISSED_EMI_PAYMENT:

  • update 3:

    • Remove params
  • on_update 3:

    • In payments, with status DELAYED has incorrect label.
    • In Payments, with status MISSED_EMI_PAYMENT has incorrect range values.
  • on_update 4:

    • In context, message_id in not unique.

Flow 4 FORECLOSURE:

  • update 3:
    • Remove params
    • Remove fulfillments

on_update 3 / 4:

  • Payment objects are invalid, incorrect values for payment statuses & missing payment link.

@Avijeet-Blocsol
Copy link
Contributor Author

on_confirm:
Invalid fulfillment state.

The fulfillment state we have mentioned is INITIATED which matches what we get with Pramaan? Is it supposed to be SANCTIONED? Please clarify. We have separate on_status calls with the SANCTIONED and DISBURSED states.

on_update 2:
Invalid fulfillment state.

The fulfillment state we have mentioned is INITIATED which matches what we get with Pramaan? Is it supposed to be SANCTIONED? Please clarify. We have separate on_status calls with the SANCTIONED and DISBURSED states.

@anuj-ondc
Copy link

In on_confirm, fulfilment state needs to SANCTIONED, also when the state is SANCTIONED, we only share the loan documents.

@Avijeet-Blocsol
Copy link
Contributor Author

Hello Anuj,

Please clarify what you mean when you say we only share the loan documents? Please confirm the following points:

  1. The state in on_confirm needs to be SANCTIONED
    In case bank account monitoring consent is required, the state should be sanctioned in the on_update_2 and not in on_confirm right? As per our communication with lenders, they do not sanction loan in case monitoring consent is required and the customer did not provide the consent.

Also some lenders do not mark the state as SANCTIONED even in the on_update_2 call. They do it via a separate on_status call (on_status_5 for SANCTION and on_status_6 for DISBURSED) in our case

  1. After sending SANCTIONED state, we dont share the LOAN CANCELLATION DOCUMENTS?

@anuj-ondc
Copy link

@Avijeet-Blocsol, After an internal team discussion, we have concluded that the findings related to the fulfillment state in on_confirm and on_update are being marked as false positives, as these values may vary based on the lender's implementation.
Please fix other findings.

@anuj-ondc
Copy link

@Avijeet-Blocsol, fix below findings:

common issues:

  • timestamp should be greater than previous call.

Flow 1
confirm:

  • formId, is different from previous call.

Flow 3:

  • on_update 4:
    • for MISSED_EMI_PAYMENT, remove payment URL.

@Avijeet-Blocsol
Copy link
Contributor Author

We have updated the logs as per the recommendations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants