Boho TRV 11 logs

[aagmanbhatt]

No description provided.

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
7620759	Triggered	Generic High Entropy Secret	79fc7a9	TRV11/Boho/Flow 1/on_confirm.json	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[amitsinha07]

Feedbacks for IGM

Issue

Organization Name and Domain Mismatch:

• Organization's name in message/issue/issue_actions/complainant_actions/[0] does not match the BAP ID.
• Organization's domain in message/issue/issue_actions/complainant_actions/[0] does not match the domain in context.

Issue Close

• issue/id is not matching with other issue APIs.
• Created At Mismatch: created_at in issue_close does not match created_at in the issue call.
• Organization Name and Domain Mismatch:
  • Organization's name in /issue_close API does not match the BAP ID.
  • Organization's domain in /issue_close API does not match the domain in context.
• Missing Object: Message/issue/complaint_actions/open object is missing.

On-Issue Status

• API Contract Violation: Message/issue/resolution_provider should not be present as per the API contract.

On-Issue Status Unsolicited

• Missing City: context must have the required property 'city'.
• TTL Value Error: TTL = PT30S is required as per the API contract.
• Missing Domain Name: Message/issue/resolution_providers/respondent_info/organization/org/name is missing the domain name.

[sourabhsaini11]

@aagmanbhatt, fix below issues as well
init, confirm, on_init, on_confirm, on_status

• missing SETTLEMENT_TERMS tag-group at payments

also missing soft-cancel pair api call for flow-2

[aagmanbhatt]

On-Issue Status
API Contract Violation: Message/issue/resolution_provider should not be present as per the API contract.

On-Issue Status Unsolicited
Missing City: context must have the required property 'city'.
TTL Value Error: TTL = PT30S is required as per the API contract.
Missing Domain Name: Message/issue/resolution_providers/respondent_info/organization/org/name is missing the domain name.

@amitsinha07 these 2 errors are on sellerapi , which is pramaan in this case.

[aagmanbhatt]

Hi @sourabhsaini11 @amitsinha07 , changes have been made please review

[sourabhsaini11]

@aagmanbhatt
common_issues

• billing.phone must be a valid phone number
• tag SETTLEMENT_AMOUNT value should be 43.56(flow-1) & 87.12(flow-2) respectively depending upon buyer-finder-fee