-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ftdev preprod verification logs #1820
base: main
Are you sure you want to change the base?
ftdev preprod verification logs #1820
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7620759 | Triggered | Generic High Entropy Secret | 9094afb | TRV11/ftdev/Flow1/on_status.json | View secret |
7620759 | Triggered | Generic High Entropy Secret | 9094afb | TRV11/ftdev/Flow1/on_confirm.json | View secret |
7620759 | Triggered | Generic High Entropy Secret | 9094afb | TRV11/ftdev/Flow1/on_status.json | View secret |
7620759 | Triggered | Generic High Entropy Secret | 9094afb | TRV11/ftdev/Flow1/on_confirm.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@priyadharshinivk, you have multiple PR's raised for same logs. Kindly maintain just a single PR active for log-verification & get the other PR's closed |
@priyadharshinivk, please fix below issues
on_search2
confirm
on_confirm
status
|
@priyadharshinivk, it's a gentle reminder to close other PR's raised from your end. |
@priyadharshinivk, update here once all the issues are resolved from your end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have closed the other PR's that I raised.
2.All common issues have been resolved and updated. Please kindly check and update as needed.
@priyadharshinivk, resolve below issues
on_select
confirm
on_confirm
status
cancel(confirm)
on_cancel
|
@sourabhsaini11 Can you name the API that is missing the INTERMEDIATE_STOP stops for the /on_action call? |
@priyadharshinivk, if the START & END stops are having other stops in b/w both of them then INTERMEDIATE_STOP should be present in all the on_action calls. |
No description provided.