Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working capital logs #1789

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Aniketdhama
Copy link

Logs for working capital FIS12 (credit)

@simranOndc
Copy link

@92shreyansh This is for Pramaan.

@92shreyansh 92shreyansh added the FIS-12 Financial Services - Credit label Nov 19, 2024
@sourabhsaini11
Copy link

@Aniketdhama, please fix below issues
on_search_1

  • head.descriptor.name should be BANK_STATEMENT AND GST RETURNS

on_search_2

  • head.descriptor.name should be BUSINESS AND FINANCIAL DOCUMENTS

on_search_3

  • fulfillments is sent additionally at message.catalog, should be part of providers

select_1

  • fulfillments is sent additionally at order.provider, should be part of message.order

on_select_1

  • fulfillments shouldn't be part of providers, should be at message.order
  • missing fulfillments, items.category_ids, items.fulfillment_ids, item.price are missing

on_status_1

  • missing fulfillments, items.category_ids, items.fulfillment_ids, item.price are missing
  • fulfillments shouldn't be part of providers, should be at message.order
  • form_response.status should be SUCCESS instead of APPROVED

select_2

  • fulfillments is sent additionally at order.provider, should be part of message.order

on_select_2

  • fulfillments shouldn't be part of providers, should be at message.order
  • for tags KYC, INDIVIDUAL_KYC, BUSINESS_KYC their values should change from PENDING to COMPLETED

on_select_3

  • fulfillments shouldn't be part of providers, should be at message.order
  • for tags INDIVIDUAL_KYC, BUSINESS_KYC their values should change from PENDING to COMPLETED

init

  • fulfillments is sent additionally at order.provider, should be part of message.order

on_init_1

  • fulfillments shouldn't be part of providers, should be at message.order
  • for tag INDIVIDUAL_KYC values should change from PENDING to COMPLETED
  • head.descriptor.name should be Account Information

on_init_2

  • fulfillments shouldn't be part of providers, should be at message.order
  • for tag INDIVIDUAL_KYC values should change from PENDING to COMPLETED
  • head.descriptor.name should be Enach

on_status_2

  • fulfillments shouldn't be part of providers, should be at message.order
  • form_response.status should be SUCCESS instead of APPROVED
  • for tags PERSONAL_DISCUSSION, INDIVIDUAL_KYC, BUSINESS_KYC, PHYSICAL_VERIFICATION,ENACH, PROCESSING_FEE & ESIGN their values should change from PENDING to COMPLETED
  • missing tag-groups BAP_TERMS & BPP_TERMS

on_init_3

  • fulfillments shouldn't be part of providers, should be at message.order
  • for tag INDIVIDUAL_KYC values should change from PENDING to COMPLETED
  • head.descriptor.name should be Enach
  • for tags PERSONAL_DISCUSSION, INDIVIDUAL_KYC, BUSINESS_KYC, PHYSICAL_VERIFICATION,ENACH, PROCESSING_FEE their values should change from PENDING to COMPLETED
  • id is missing in payments

on_status_3

  • fulfillments shouldn't be part of providers, should be at message.order
  • form_response.status should be SUCCESS instead of APPROVED
  • for tags PERSONAL_DISCUSSION, INDIVIDUAL_KYC, BUSINESS_KYC, PHYSICAL_VERIFICATION,ENACH, PROCESSING_FEE & ESIGN their values should change from PENDING to COMPLETED
  • missing tag-groups BAP_TERMS & BPP_TERMS
  • id is missing in payments

confirm

  • missing fulfillments at message.order
  • missing tag-groups BAP_TERMS & BPP_TERMS

on_confirm

  • fulfillments shouldn't be part of providers, should be at message.order
  • for tags PERSONAL_DISCUSSION, INDIVIDUAL_KYC, BUSINESS_KYC, PHYSICAL_VERIFICATION,ENACH, PROCESSING_FEE & ESIGN their values should change from PENDING to COMPLETED
  • missing tag-groups BAP_TERMS & BPP_TERMS

common_issue

  • xinput.form.id shouldn't be localhost
  • incorrect titles present in quote.breakup(PRINCIPAL, INTEREST) & some titles are missing
  • missing tag-group BAP_TERMS for /action calls
  • missing tag-group BPP_TERMS for /on_action calls

@simranOndc
Copy link

@sourabhsaini11 Please check the logs, these are for all the pending flows.

@sourabhsaini11
Copy link

@Aniketdhama, please fix below issues as well
on_search_2

  • wrong value, why is head.descriptor.name reflecting 'Customer Information' at xinput.head. Should be on basis of current index

on_search_3

  • customer info sent at /search_3 doesn't by the BAP doesn't match with customer info reflected by the BPP customer.contact & customer.person.name

select_3

  • fulfillments is missing

on_init_1

  • for tag BUSINESS_KYC, value should be PENDING
  • BPP_TERMS should be present instead of BAP_TERMS

on_init_2

  • for tags PERSONAL_DISCUSSION & PHYSICAL_VERIFICATION, value should be COMPLETED
  • BPP_TERMS should be present instead of BAP_TERMS
  • why is payments.params.amount value same as API-Contract if item's value is not same

init_3

  • tags are sent additionally in fulfillments
  • multiple BAP_TERMS tag-groups present

on_init_3

  • for tag ESIGN, value should be PENDING
  • BPP_TERMS should be present instead of BAP_TERMS
  • why is payments.params.amount value same as API-Contract if item's value is not same

confirm

  • tags are sent additionally in fulfillments
  • multiple BAP_TERMS tag-groups present

on_confirm

  • missing cancellation_terms, documents
  • customer.person.creds should be an array
  • missing tags in fulfillments
  • multiple BAP_TERMS tag-groups present, missing BPP_TERMS

on_status

  • xinput.form_response.status should be SUCCESS
  • multiple BAP_TERMS tag-groups present, missing BPP_TERMS
  • for tag ESIGN, value should be COMPLETED (/on_status_3 only)

common_issue

  • quote.breakup contains invalid titles, please re-check contract & upload correct quote object
  • why is xinput.form.url & payments.url pointing to a locally hosted endpoint
  • payments.collected_by can only be either BPP or BAP, remove other values like MERCHANT

Flow-3
on_update

  • fulfillments.name should be string, missing creds, dob & gender at person as well
  • stops are not required at fulfillments
  • multiple BAP_TERMS tag-groups present, missing BPP_TERMS
  • fulfillment_ids & tags should not be empty at items
  • multiple indexes present in payments, size should be 1 (/on_update_3 only)
  • missing tags at fulfillments (/on_update_3 only)

Flow-4
on_update (1 & 2)

  • fulfillments.name should be string, missing creds, dob & gender at person as well
  • stops are not required at fulfillments
  • multiple BAP_TERMS tag-groups present, missing BPP_TERMS
  • fulfillment_ids & tags should not be empty at items
  • transaction_id & time.timestamp are missing for PAID status at payments

on_update_3

  • fulfillments.name should be string, missing creds, dob & gender at person as well
  • missing tags at fulfillments
  • stops are not required at fulfillments
  • multiple BAP_TERMS tag-groups present, missing BPP_TERMS
  • fulfillment_ids & tags should not be empty at items
  • multiple indexes present in payments, size should be 1

Flow-4
on_update

  • fulfillments.name should be string, missing creds, dob & gender at person as well
  • missing tags at fulfillments
  • stops are not required at fulfillments
  • multiple BAP_TERMS tag-groups present, missing BPP_TERMS
  • fulfillment_ids & tags should not be empty at items
  • missing collected_by at payments[0]

Flow-5
on_cancel

  • timestamp can't be same as /cancel timestamp
  • How can message part of payload for both /on_cancel & on_update calls be same as the contract

@Aniketdhama
Copy link
Author

logs has been update @sourabhsaini11

@simranOndc
Copy link

@sourabhsaini11 Please have a look and update.

@sourabhsaini11
Copy link

@Aniketdhama
search

  • missing tags BUYER_FINDER_FEES_TYPE, BUYER_FINDER_FEES_PERCENTAGE & DELAY_INTEREST at BAP_TERMS

on_search(1, 2, 3)

  • missing tags BUYER_FINDER_FEES_TYPE, BUYER_FINDER_FEES_PERCENTAGE, SETTLEMENT_BASIS, MANDATORY_ARBITRATION, COURT_JURISDICTION & SETTLEMENT_WINDOW at BAP_TERMS

common_issues

  • How can fulfillment.customer info be same as api-contract
  • incorrect titles present in quote.breakup(PRINCIPAL, INTEREST) present instead WOKRKING_CAPITAL_LIMIT & CURRENT_UTLIZATION should be used
  • missing init_4 & on_init_4 action calls

on_search_3

  • fulfillments obj mismatch b/w search_3 & on_search_3
  • parent_item_id should match to item.id provided in previous on_action call

on_status_1

  • form_response.status should be SUCCESS instead of APPROVED

on_select_2

  • INDIVIDUAL_KYC their values should change from COMPLETED to PENDING

on_select_3

  • CHECKLISTS tag-group is missing for fufillments objects
  • xinput should consist of form.id & form.form_response

init

  • missing tags BUYER_FINDER_FEES_TYPE, BUYER_FINDER_FEES_PERCENTAGE, SETTLEMENT_TYPE & DELAY_INTEREST at BAP_TERMS

on_init

  • missing tags BUYER_FINDER_FEES_TYPE, BUYER_FINDER_FEES_PERCENTAGE, SETTLEMENT_BASIS, MANDATORY_ARBITRATION, COURT_JURISDICTION, SETTLEMENT_BASIS, SETTLEMENT_AMOUNT & SETTLEMENT_WINDOW at BAP_TERMS

on_status_2

  • for tags E_SIGN, ENACH, PROCESSING_FEE their values should change from PENDING to COMPLETED
  • form_response.status should be SUCCESS instead of APPROVED
  • id is missing in payments
  • missing tags BUYER_FINDER_FEES_TYPE, BUYER_FINDER_FEES_PERCENTAGE, SETTLEMENT_BASIS, MANDATORY_ARBITRATION, COURT_JURISDICTION, SETTLEMENT_BASIS, SETTLEMENT_AMOUNT & SETTLEMENT_WINDOW at BAP_TERMS
  • url is sent additionally in payments

init_3

  • form_response.status should be SUCCESS instead of APPROVED

on_init_3

  • for tags ENACH, PROCESSING_FEE their values should change from PENDING to COMPLETED
  • url is sent additionally in payments

on_status_3

  • for tags E_SIGN, ESIGN, ENACH, PROCESSING_FEE their values should change from PENDING to COMPLETED
  • url is sent additionally in payments
  • missing tags BUYER_FINDER_FEES_TYPE, BUYER_FINDER_FEES_PERCENTAGE, SETTLEMENT_BASIS, MANDATORY_ARBITRATION, COURT_JURISDICTION, SETTLEMENT_BASIS, SETTLEMENT_AMOUNT & SETTLEMENT_WINDOW, OFFLINE_CONTRACT at BAP_TERMS
  • form_response.status should be SUCCESS instead of APPROVED

confirm

  • missing tags BUYER_FINDER_FEES_TYPE, BUYER_FINDER_FEES_PERCENTAGE, SETTLEMENT_TYPE & DELAY_INTEREST at BAP_TERMS
  • missing BPP_TERMS

on_confirm

  • for tags E_SIGN, ESIGN, ENACH, PROCESSING_FEE their values should change from PENDING to COMPLETED
  • missing created_at & updated_at
  • url is sent additionally in payments
  • missing BPP_TERMS
  • missing tags BUYER_FINDER_FEES_TYPE, BUYER_FINDER_FEES_PERCENTAGE, SETTLEMENT_BASIS, MANDATORY_ARBITRATION, COURT_JURISDICTION, SETTLEMENT_BASIS, SETTLEMENT_AMOUNT & SETTLEMENT_WINDOW, OFFLINE_CONTRACT at BAP_TERMS

@simranOndc
Copy link

@sourabhsaini11 above mentioned issues are resolved and logs are updated, please check and update.

@Aniketdhama Please see, this is closed asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIS-12 Financial Services - Credit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants